feat: aggregations based on formula result

packages/nc-gui/components/smartsheet/grid/PaginationV2.vue

@@ -77,7 +77,7 @@ onMounted(() => {
         <template #overlay>
           <NcMenu>
             <NcMenuItem
-              v-for="(agg, index) in getAggregations(displayFieldComputed.column.uidt, true)"
+              v-for="(agg, index) in getAggregations(displayFieldComputed.column, true)"
               :key="index"
               @click="updateAggregate(displayFieldComputed.column.id, agg)"
             >
@@ -123,11 +123,7 @@ onMounted(() => {
 
         <template #overlay>
           <NcMenu>
-            <NcMenuItem
-              v-for="(agg, index) in getAggregations(column.uidt)"
-              :key="index"
-              @click="updateAggregate(column.id, agg)"
-            >
+            <NcMenuItem v-for="(agg, index) in getAggregations(column)" :key="index" @click="updateAggregate(column.id, agg)">
               <div class="flex !w-full text-gray-800 items-center justify-between">
                 {{ $t(`aggregation_type.${agg}`) }}
 

packages/nc-gui/composables/useViewAggregate.ts

@@ -1,5 +1,5 @@
 import type { Ref } from 'vue'
-import { CommonAggregations, type TableType, type ViewType, getAvailableAggregations } from 'nocodb-sdk'
+import { type ColumnType, CommonAggregations, type TableType, UITypes, type ViewType, getAvailableAggregations } from 'nocodb-sdk'
 
 const [useProvideViewAggregate, useViewAggregate] = useInjectionState(
   (
@@ -56,8 +56,14 @@ const [useProvideViewAggregate, useViewAggregate] = useInjectionState(
       }
     })
 
-    const getAggregations = (type: string, hideNone?: boolean) => {
-      const agg = getAvailableAggregations(type)
+    const getAggregations = (column: ColumnType, hideNone?: boolean) => {
+      let agg
+      if (column.uidt === UITypes.Formula && (column.colOptions as any)?.parsed_tree?.dataType) {
+        agg = getAvailableAggregations(column.uidt!, (column.colOptions as any).parsed_tree)
+      } else {
+        agg = getAvailableAggregations(column.uidt!)
+      }
+
       if (hideNone) {
         return agg.filter((x) => x !== 'none')
       }

packages/nocodb-sdk/src/lib/aggregationHelper.ts

@@ -1,4 +1,5 @@
 import UITypes from './UITypes';
+import { FormulaDataTypes } from '~/lib/formulaHelpers';
 
 enum NumericalAggregations {
   Sum = 'sum',
@@ -48,7 +49,26 @@ const AllAggregations = {
   ...DateAggregations,
 };
 
-const getAvailableAggregations = (type: string): string[] => {
+const getAvailableAggregations = (type: string, parsed_tree?): string[] => {
+  if (type === UITypes.Formula && parsed_tree?.dataType) {
+    switch (parsed_tree.dataType) {
+      case FormulaDataTypes.BOOLEAN:
+        return [...Object.values(BooleanAggregations), CommonAggregations.None];
+      case FormulaDataTypes.DATE:
+        return [
+          ...Object.values(DateAggregations),
+          ...Object.values(CommonAggregations),
+        ];
+      case FormulaDataTypes.NUMERIC:
+        return [
+          ...Object.values(NumericalAggregations),
+          ...Object.values(CommonAggregations),
+        ];
+      default:
+        return [...Object.values(CommonAggregations)];
+    }
+  }
+
   switch (type) {
     case UITypes.Number:
     case UITypes.Decimal:

packages/nocodb/src/db/aggregation.ts

@@ -3,6 +3,7 @@ import {
   BooleanAggregations,
   CommonAggregations,
   DateAggregations,
+  FormulaDataTypes,
   getAvailableAggregations,
   NumericalAggregations,
   UITypes,
@@ -16,7 +17,10 @@ import genRollupSelectv2 from '~/db/genRollupSelectv2';
 import generateLookupSelectQuery from '~/db/generateLookupSelectQuery';
 
 const validateColType = (column: Column, aggregation: string) => {
-  const agg = getAvailableAggregations(column.uidt);
+  const agg = getAvailableAggregations(
+    column.uidt,
+    column.colOptions?.parsed_tree,
+  );
 
   if (!agg.includes(aggregation)) {
     NcError.badRequest(
@@ -122,6 +126,8 @@ export default async function applyAggregation({
   if (_column.uidt === UITypes.LastModifiedBy && !_column.column_name)
     column = 'updated_by';
 
+  const parsedFormulaType = _column.colOptions?.parsed_tree?.dataType;
+
   /* The following column types require special handling for aggregation:
    * - Links
    * - Rollup
@@ -161,7 +167,6 @@ export default async function applyAggregation({
       break;
   }
   let secondaryCondition: any = "''";
-
   if (
     [
       UITypes.CreatedTime,
@@ -178,7 +183,10 @@ export default async function applyAggregation({
       UITypes.Rollup,
       UITypes.Links,
       UITypes.ID,
-    ].includes(_column.uidt)
+    ].includes(_column.uidt) ||
+    [FormulaDataTypes.DATE, FormulaDataTypes.NUMERIC].includes(
+      parsedFormulaType,
+    )
   ) {
     secondaryCondition = 'NULL';
   } else if ([UITypes.Rating].includes(_column.uidt)) {
@@ -224,7 +232,10 @@ export default async function applyAggregation({
             UITypes.Rollup,
             UITypes.Links,
             UITypes.ID,
-          ].includes(_column.uidt)
+          ].includes(_column.uidt) ||
+          [FormulaDataTypes.DATE, FormulaDataTypes.NUMERIC].includes(
+            parsedFormulaType,
+          )
         ) {
           aggregationSql = knex.raw(
             `COUNT(*) FILTER (WHERE (??) IS NOT NULL) AS ??`,
@@ -266,7 +277,10 @@ export default async function applyAggregation({
             UITypes.Rollup,
             UITypes.Links,
             UITypes.ID,
-          ].includes(_column.uidt)
+          ].includes(_column.uidt) ||
+          [FormulaDataTypes.DATE, FormulaDataTypes.NUMERIC].includes(
+            parsedFormulaType,
+          )
         ) {
           aggregationSql = knex.raw(
             `COUNT(DISTINCT (??)) FILTER (WHERE (??) IS NOT NULL) AS ??`,
@@ -312,7 +326,10 @@ export default async function applyAggregation({
             UITypes.Rollup,
             UITypes.Links,
             UITypes.ID,
-          ].includes(_column.uidt)
+          ].includes(_column.uidt) ||
+          [FormulaDataTypes.DATE, FormulaDataTypes.NUMERIC].includes(
+            parsedFormulaType,
+          )
         ) {
           aggregationSql = knex.raw(
             `(COUNT(*) FILTER (WHERE (??) IS NOT NULL) * 100.0 / NULLIF(COUNT(*), 0)) AS ??`,
@@ -352,7 +369,10 @@ export default async function applyAggregation({
             UITypes.Rollup,
             UITypes.Links,
             UITypes.ID,
-          ].includes(_column.uidt)
+          ].includes(_column.uidt) ||
+          [FormulaDataTypes.DATE, FormulaDataTypes.NUMERIC].includes(
+            parsedFormulaType,
+          )
         ) {
           aggregationSql = knex.raw(
             `(COUNT(DISTINCT (??)) FILTER (WHERE (??) IS NOT NULL) * 100.0 / NULLIF(COUNT(*), 0)) AS ??`,