refactor: Plugins return again (#820)

* refactor: plugins return again

* docs: update changelog and version

CHANGELOG.md

@@ -1,6 +1,10 @@
 # Changelog
 
 
+### 3.2.2
+
+ * refactor: ([#801](https://github.com/node-formidable/formidable/pull/801))
+
 ### 3.2.1
 
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "formidable",
-  "version": "3.2.1",
+  "version": "3.2.2",
   "license": "MIT",
   "description": "A node.js module for parsing form data, especially file uploads.",
   "homepage": "https://github.com/node-formidable/formidable",

src/Formidable.js

@@ -407,9 +407,11 @@ class IncomingForm extends EventEmitter {
 
     new DummyParser(this, this.options);
 
-    this._plugins.forEach((plugin, idx) => {  
+    const results = [];
+    this._plugins.forEach((plugin, idx) => {
+      let pluginReturn = null;
       try {
-        plugin(this, this.options) || this;
+        pluginReturn = plugin(this, this.options) || this;
       } catch (err) {
         // directly throw from the `form.parse` method;
         // there is no other better way, except a handle through options
@@ -421,10 +423,12 @@ class IncomingForm extends EventEmitter {
         error.idx = idx;
         throw error;
       }
+      Object.assign(this, pluginReturn);
 
       // todo: use Set/Map and pass plugin name instead of the `idx` index
-      this.emit('plugin', idx);
+      this.emit('plugin', idx, pluginReturn);
     });
+    this.emit('pluginsResults', results);
   }
 
   _error(err, eventName = 'error') {

src/plugins/json.js

@@ -14,6 +14,8 @@ export default function plugin(formidable, options) {
   if (/json/i.test(self.headers['content-type'])) {
     init.call(self, self, options);
   }
+
+  return self;
 };
 
 // Note that it's a good practice (but it's up to you) to use the `this.options` instead

src/plugins/multipart.js

@@ -33,6 +33,7 @@ export default function plugin(formidable, options) {
       self._error(err);
     }
   }
+  return self;
 }
 
 // Note that it's a good practice (but it's up to you) to use the `this.options` instead

src/plugins/octetstream.js

@@ -14,6 +14,7 @@ export default function plugin(formidable, options) {
   if (/octet-stream/i.test(self.headers['content-type'])) {
     init.call(self, self, options);
   }
+  return self;
 }
 
 // Note that it's a good practice (but it's up to you) to use the `this.options` instead

src/plugins/querystring.js

@@ -15,6 +15,7 @@ export default function plugin(formidable, options) {
   if (/urlencoded/i.test(self.headers['content-type'])) {
     init.call(self, self, options);
   }
+  return self;
 };
 
 // Note that it's a good practice (but it's up to you) to use the `this.options` instead