Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove EventEmitter from 'event' module #23

Merged
merged 1 commit into from
Nov 11, 2015
Merged

feat: remove EventEmitter from 'event' module #23

merged 1 commit into from
Nov 11, 2015

Conversation

nightink
Copy link
Contributor

remove EventEmitter from 'event' module
set package engines field

nodejs/node#2921
nodejs/node@6ed861d

@codecov-io
Copy link

Current coverage is 97.66%

Merging #23 into master will not affect coverage as of 9d1f44d

@@            master     #23   diff @@
======================================
  Files            3       3       
  Stmts          257     257       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit            251     251       
  Partial          0       0       
  Missed           6       6

Review entire Coverage Diff as of 9d1f44d

Powered by Codecov. Updated on successful CI builds.

fengmk2
fengmk2 reviewed Nov 11, 2015
View reviewed changes
package.json
@@ -47,6 +47,10 @@
"mock",
"test"
],
"engines": {
"iojs": ">=1.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just node, iojs was deped.

@nightink
feat: remove EventEmitter from 'event' module
c94fb99 
remove EventEmitter from 'event' module
set package engines field
@nightink
Copy link
Contributor Author

done!

@fengmk2
Copy link
Member

fengmk2 commented Nov 11, 2015

+1

fengmk2 added a commit that referenced this pull request Nov 11, 2015
@fengmk2
Merge pull request #23 from nightink/patch-1
139b8f6 
feat: remove EventEmitter from 'event' module
@fengmk2 fengmk2 merged commit 139b8f6 into node-modules:master Nov 11, 2015
@nightink nightink deleted the patch-1 branch November 11, 2015 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nightink @codecov-io @fengmk2