close verifyTask when there is no valid peer and add UT tests #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryyl
force-pushed
the
separate-node-test
branch
from
9ef971f
to
0132f13
Compare
dean65
force-pushed
the
separate-node-test
branch
from
0132f13
to
9602878
Compare
cryyl
force-pushed
the
separate-node-test
branch
from
9602878
to
bf03944
Compare
dean65
force-pushed
the
separate-node-test
branch
from
bf03944
to
0132f13
Compare
unclezoro
approved these changes
Apr 29, 2022
realuncle
approved these changes
Apr 29, 2022
dean65
reviewed
Apr 29, 2022
| resp := verifier.GetRootByDiffHash(req.blockNumber, req.blockHash, req.diffHash) | ||
| if failed != nil && req.blockNumber == failed.blockNumber { | ||
| resp.Status = failed.status | ||
| } else { |
There was a problem hiding this comment.
we can remove this else condition to keep the original status that response from the verifier.
NashBC
approved these changes
Apr 29, 2022
calmbeing
pushed a commit
that referenced
this pull request
May 20, 2022
* feat: integration for BEP-127 * fix: euler config order * fix: init code * feat: integration for BEP-131 * fix: update RialtoGenesisHash * feat: upgrade euler height * feat: upgrade euler height and Validator contract byte code * feat: modify railto genesis hash * feat: modify railto genesis hash * TODO: add comment to make sure upgrade height is not an integer multiple of 200(epoch number) * force check that Euler height cannot be a multiple of 200 * fix String() function of ChainConfig * add simple aggragate votes * fix missing parent assign issue Co-authored-by: zjubfd <296179868@qq.com> Co-authored-by: soliditygo <soliditygo@outlook.com> Co-authored-by: dean65 <dean950605@gmail.com> Co-authored-by: Gothery <90246878+gothery001@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
close verifyTask when there is no valid peer and add UT tests
Rationale
tell us why we need these changes...
Example
add an example CLI or API response...
Changes
Notable changes: