New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new themes introduced in @node-red-contrib-themes/theme-collection v3.1 #29

Merged

knolleary merged 1 commit into node-red:master from bonanitech:v3.1-themes

Jun 3, 2024

Contributor

bonanitech commented Sep 6, 2023

Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)

Proposed changes

Node-RED Contrib Theme Collection version 3.1 introduced new themes:

github-dark
github-dark-default
github-dark-dimmed
monokai-dimmed
noctis
one-dark-pro
one-dark-pro-darker
tokyo-night-light
tokyo-night-storm
totallyinformation

This PR adds them as options.

Checklist

I have read the contribution guidelines
For non-bugfix PRs, I have discussed this change on the forum/slack team.
I have run grunt to verify the unit tests pass
I have added suitable unit tests to cover the new/changed functionality


          Add themes introduced in v3.1

c6e1ec1

Member

knolleary commented May 28, 2024

@bonanitech sorry for not getting to this for so long. Wanted to check if there were any further updates needed since the original PR?

Contributor Author

bonanitech commented May 28, 2024 •

edited

Loading

No problem. I'm not adding new themes in 4.0. Thanks for asking.

Edit: I mean, this PR can be merged as is.

knolleary merged commit 99b6b0b into node-red:master

4 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet