util.callbackify for async functions

[benjamingr]

Hey,

From nodejs/promises#6 originally, but seeing that util.promisify is finally in sight, I think this might be worth proposing too.

I propose that for compatibility reasons, and so that callback users using Node can keep working with their tooling to add a util.callbackify function that converts an async function to a callback taking function.

For example:

async function foo() {
  let data1 = await promiseApi(..);
  let data2 = await promiseApiOther(data1);
  return result;
}
const foo2 = util.callbackify(foo);
foo2(function(err, data) {
  // error here if foo threw
  // use data here
});

This is likely faster in core, and would enable seamless integration of async functions into callback APIs and code bases. Seeing as we're not going to make a promisified core any time soon - this is beneficial for interoping between code bases using callbacks and async functions together.

How do @nodejs/collaborators feel about this?

[mcollina]

I think we need this if we want to ship promisify.

[Qard]

👍 from me. Regardless of how core feels about promises and async/await, userland will use them, so we need to ensure interop works well.

[cjihrig]

I think it makes sense if promisify makes it in.

[vkurchatkin]

-1 unless we have something to offer in terms of performance

[bnoordhuis]

Someone has to say it: s/toCallback/callbackify/

[evanlucas]

Someone has to say it: s/toCallback/callbackify/

Yea, can we be consistent?

[benjamingr]

@bnoordhuis @evanlucas this issue was mostly to see if there is interest - I've amended to callbackify.

[refack]

At the moment I see 20 👍 so
😀me
gauntlet
🏋️‍Picking up

(ouch! my back 😖)

[refack]

@not-an-aardvark I'm working on a PR, finishing some tests and will upload tomorrow for you'll to review...

[eljefedelrodeodeljefe]

I'd be happy if we could push nodejs/node#12712 forward.

[refack]

I believe this could be closed now that nodejs/node@af3aa68 landed

[benjamingr]

Sweet! Thanks a lot @refack :)