Skip to content

Commit

Permalink
Propose vote to unblock --env-file PRs (#1577)
Browse files Browse the repository at this point in the history
* Propose vote to unblock `--env-file` PRs

Refs: #1575 (comment)

* Apply suggestions from code review

Co-authored-by: Tobias Nießen <tniessen@tnie.de>

* Apply suggestions from code review

* Apply suggestions from code review

---------

Co-authored-by: Tobias Nießen <tniessen@tnie.de>
  • Loading branch information
aduh95 and tniessen committed Jun 17, 2024
1 parent f523773 commit de78d34
Showing 1 changed file with 16 additions and 5 deletions.
21 changes: 16 additions & 5 deletions votes/initiateNewVote/_EDIT_ME.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

# 1. Select a subject for the vote. This can be a question addressed to the TSC
# voting members.
subject: REPLACEME
subject: How should `node` handle non-existent `.env` files passed via CLI flags?

# 2. You can leave the header instructions as is, or modify them if you see fit.
headerInstructions: |
Expand All @@ -24,8 +24,14 @@ headerInstructions: |
# voters express their preference for each candidates, no matter how many
# there are.
candidates:
- TODO
- TODO
- Throw when passed to `--env-file` flag, provide no other flag (status quo).
- Ignore when passed to `--env-file` flag, provide no other flag.
- Warn when passed to `--env-file` flag, provide no other flag.
- Throw when passed to `--env-file` flag, warn when passed to a new `--env-file-if-exists`.
- Throw when passed to `--env-file` flag, ignore when passed to a new `--env-file-if-exists`.
- Ignore when passed to `--env-file` flag, throw when passed to a new `--env-file-must-exist`.
- Throw when passed to `--env-file` flag, unless new `--env-file-when-missing=warn` is also passed.
- Warn when passed to `--env-file` flag, unless new `--env-file-when-missing=throw` is also passed.

# 4. Pass the following to false if it's important to keep the candidates in the
# order you define above. Presenting candidates in a fixed order tends to
Expand All @@ -35,11 +41,16 @@ canShuffleCandidates: true
# 5. Insert here a short description of the vote objectives and link to the
# issue it was discussed on to give the full context.
footerInstructions: |
TBD
Based on the result of this vote, we can unblock either https://github.com/nodejs/node/pull/53177,
https://github.com/nodejs/node/pull/53060, or neither if the status quo prevails. The name of the
proposed flags are non-binding, and are provided only as examples. If a proposal that includes a
new flag is accepted, the name of that flag can be bike-shed per the PR review process.
"Ignore" means "do not throw and do not warn" in this context.
# 6. Optionally, insert a brief introduction for the vote PR, in the markdown format.
prBody: |
The vote should stay open for 7 days, or until all TSC voting members have cast a ballot.
# 7. Optionally, choose an id that will be used for the branch name as well as
# the vote folder name. If not supplied, a UUID will be used.
path-friendly-id: null
path-friendly-id: how-to-handle-missing-env-files

0 comments on commit de78d34

Please sign in to comment.