Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jenkins: remove v16 from VersionSelectorScript #3489

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

targos
Copy link
Member

@targos targos commented Sep 18, 2023

No description provided.

@richardlau
Copy link
Member

It's written down that we keep stuff around for 6 months after a release line goes End-of-Life before removing.

build/README.md

Lines 294 to 296 in 2e7c763

The Build WG will keep build configuration required for a release line for 6
months after the release goes End-of-Life, in case further build or test runs
are required. After that the configuration will be removed.

FWIW I can only remember one time when we decided to do an additional release after End-of-Life, which IIRC was within the month after the End-of-Life.

@targos targos marked this pull request as draft September 19, 2023 07:36
@mhdawson
Copy link
Member

I would be good to keep this around a bit longer if possible. I don't think it hurts anything, right?

@targos
Copy link
Member Author

targos commented Sep 27, 2023

That's why I made this a draft. I'll come back to it in 6 months.

@targos targos marked this pull request as ready for review April 7, 2024 13:09
@targos
Copy link
Member Author

targos commented Apr 11, 2024

Ready for a new review.

Copy link
Contributor

@StefanStojanovic StefanStojanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Removing VS2015 and VS2017 from compilation jobs is highly optional.

EDIT: I was thinking about maybe removing the vs2015 and vs2017 compilation configurations completely, but that is not very urgent. I may open a follow-up PR for that at some point.

@targos targos merged commit eb27c6f into nodejs:main Apr 11, 2024
1 check passed
@targos targos deleted the version-selector-v16 branch April 11, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants