Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-node v8: prompt on merge conflict #307

Merged
merged 2 commits into from
Nov 14, 2018

Conversation

hashseed
Copy link
Member

Instead of performing git apply and aborting if it fails (which happens often), perform patch -p1 --merge instead to produce merge artifacts and then prompt for user input to continue.

It should look something like this:

example output

@hashseed
Copy link
Member Author

hashseed commented Nov 13, 2018

This addresses #303

@targos
Copy link
Member

targos commented Nov 13, 2018

Nice, thank you! I tested it locally and it works 👍

@targos
Copy link
Member

targos commented Nov 13, 2018

I will follow up with another PR that uses "backport" instead of "cherry-pick" in the commit message when a conflict occurs, but after #304 is landed.

@codecov
Copy link

codecov bot commented Nov 13, 2018

Codecov Report

Merging #307 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #307   +/-   ##
=======================================
  Coverage   74.03%   74.03%           
=======================================
  Files          22       22           
  Lines        1406     1406           
=======================================
  Hits         1041     1041           
  Misses        365      365

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7a1634...22315aa. Read the comment docs.

@hashseed
Copy link
Member Author

I don't actually have power to merge this :)

@targos targos merged commit d5aa22d into nodejs:master Nov 14, 2018
@targos
Copy link
Member

targos commented Nov 14, 2018

I do ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants