Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use inquirer to implement CLI.prompt #310

Merged
merged 1 commit into from
Nov 23, 2018
Merged

refactor: use inquirer to implement CLI.prompt #310

merged 1 commit into from
Nov 23, 2018

Conversation

targos
Copy link
Member

@targos targos commented Nov 20, 2018

No description provided.

@codecov
Copy link

codecov bot commented Nov 20, 2018 •
edited
Loading

Codecov Report

Merging #310 into master will increase coverage by 0.38%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #310      +/-   ##
==========================================
+ Coverage   74.03%   74.42%   +0.38%     
==========================================
  Files          22       22              
  Lines        1406     1400       -6     
==========================================
+ Hits         1041     1042       +1     
+ Misses        365      358       -7
Impacted Files Coverage Δ
lib/cli.js 59.7% <50%> (+6.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7839c2a...7e99951. Read the comment docs.

joyeecheung
joyeecheung approved these changes Nov 22, 2018
View reviewed changes
Copy link
Member

@joyeecheung joyeecheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to use it to refactor cli.promptForInput?

@targos
Copy link
Member Author

targos commented Nov 22, 2018

@joyeecheung Probably. I'll try it in another PR.

@targos targos merged commit 527ce8d into nodejs:master Nov 23, 2018
@targos targos deleted the prompt-inquirer branch November 23, 2018 07:52
@targos
Copy link
Member Author

targos commented Nov 24, 2018

@joyeecheung I see that cli.promptForInput is not used at all. Should I just remove it?

@targos
Copy link
Member Author

targos commented Nov 24, 2018

I opened #315

@refack
Copy link
Contributor

refack commented Nov 24, 2018

It was a preliminary for #299

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

@priyank-p priyank-p priyank-p approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@targos @refack @joyeecheung @priyank-p