Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

repl: fix tab completion for a non-global context #25382

Closed
wants to merge 1 commit into from
Closed

repl: fix tab completion for a non-global context #25382

wants to merge 1 commit into from

Conversation

sixmen
Copy link

@sixmen sixmen commented May 27, 2015

a context is not an instance of 'Context' from v0.11.7

a context is not an instance of 'Context' from v0.11.7
@cjihrig
Copy link

cjihrig commented May 27, 2015

LGTM. I think this should go into the 0.12 branch. I haven't tested, but this is likely an issue on io.js as well.

I think this has been slipping through the cracks because the failed assertions are not being properly reported. To see what I'm talking about, check out cjihrig/node@42e7963.

@jasnell
Copy link
Member

jasnell commented May 27, 2015

LGTM. Landing in v0.12 makes sense.

@cjihrig cjihrig added this to the 0.12.5 milestone May 28, 2015
@misterdjules misterdjules modified the milestones: 0.12.5, 0.12.6 Jun 22, 2015
@cjihrig cjihrig mentioned this pull request Jun 24, 2015
cjihrig pushed a commit to nodejs/node that referenced this pull request Jun 25, 2015
Use vm.isContext() to properly identify contexts.

PR-URL: nodejs/node-v0.x-archive#25382
PR-URL: #2052
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@misterdjules misterdjules modified the milestones: 0.12.6, 0.12.7 Jul 6, 2015
mscdex pushed a commit to mscdex/io.js that referenced this pull request Jul 9, 2015
Use vm.isContext() to properly identify contexts.

PR-URL: nodejs/node-v0.x-archive#25382
PR-URL: nodejs#2052
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@misterdjules misterdjules modified the milestones: 0.12.7, 0.12.8 Jul 10, 2015
@jasnell jasnell added the repl label Aug 27, 2015
@sixmen sixmen closed this Oct 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants