This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Reconcile v0.12 with new CI #25653
Closed
Reconcile v0.12 with new CI #25653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a minimal effort to support test output written both to stdout and file in order to get our buildbots understanding test output. Cherry picked from jbergstroem/node@3194073 Original commit message follows: PR-URL: nodejs/node#934 Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Conflicts: tools/test.py
On a few of our installations (namely CentOS), passing 'INFO' resulted in a silent loglevel. Use a logging constant instead. Cherry-picked from nodejs/node@8606793 Original commit metadata follows: Fixes: nodejs/build#104 PR-URL: nodejs/node#1842 Reviewed-By: Rod Vagg <rod@vagg.org>
| @@ -81,7 +84,6 @@ goto next-arg | |||
|
|
|||
| :args-done | |||
| if defined upload goto upload | |||
| if defined jslint goto jslint | |||
There was a problem hiding this comment.
Does vcbuild jslint still work? It seems that with this change it would only work when tests are run too.
There was a problem hiding this comment.
Good catch. This change enables building and testing, when jslint is specified. But it has the side effect of not getting to jslint unless you run tests. Will fix.
|
Thank you @orangemocha! Added a few comments. |
Adding support for specifying flaky test mode to the test runner: - via an environment variable FLAKY_TESTS for Makefile - via an argument ignore-flaky for vcbuild.bat Conflicts: Makefile
Make the test runner return a 0 exit code when only flaky tests fail and --flaky-tests=dontcare is specified.
Adding a single rule to be called from Jenkins.
|
Updated to fix extra line and jslint issue. Sneak preview CI run: https://jenkins-iojs.nodesource.com/job/orangemocha-test-commit/4/ |
|
LGTM. That's great! Do we plan to backport this to v0.10 too and test + build v0.10 releases from the converged CI? |
|
I might give it a shot, but given that we currently don't use node-accept-pull-request for v0.10, I will probably settle for just porting the current workflow, and then work on enabling node-accept-pull-request on v0.10 later. What job do you currently use on v0.10, BTW? Thanks for reviewing! |
orangemocha
added a commit
that referenced
this pull request
Jul 10, 2015
This is a minimal effort to support test output written both to stdout and file in order to get our buildbots understanding test output. Cherry picked from jbergstroem/node@3194073 Original commit message follows: PR-URL: nodejs/node#934 Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Conflicts: tools/test.py Reviewed-By: Julien Gilli <julien.gilli@joyent.com> PR-URL: #25653
orangemocha
pushed a commit
that referenced
this pull request
Jul 10, 2015
On a few of our installations (namely CentOS), passing 'INFO' resulted in a silent loglevel. Use a logging constant instead. Cherry-picked from nodejs/node@8606793 Original commit metadata follows: Fixes: nodejs/build#104 PR-URL: nodejs/node#1842 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Julien Gilli <julien.gilli@joyent.com> PR-URL: #25653
orangemocha
added a commit
that referenced
this pull request
Jul 10, 2015
Reviewed-By: Julien Gilli <julien.gilli@joyent.com> PR-URL: #25653
orangemocha
added a commit
that referenced
this pull request
Jul 10, 2015
Adding support for specifying flaky test mode to the test runner: - via an environment variable FLAKY_TESTS for Makefile - via an argument ignore-flaky for vcbuild.bat Conflicts: Makefile Reviewed-By: Julien Gilli <julien.gilli@joyent.com> PR-URL: #25653
orangemocha
added a commit
that referenced
this pull request
Jul 10, 2015
Make the test runner return a 0 exit code when only flaky tests fail and --flaky-tests=dontcare is specified. Reviewed-By: Julien Gilli <julien.gilli@joyent.com> PR-URL: #25653
orangemocha
added a commit
that referenced
this pull request
Jul 10, 2015
Adding a single rule to be called from Jenkins. Reviewed-By: Julien Gilli <julien.gilli@joyent.com> PR-URL: #25653
|
Landed in c9ef4b3. |
|
@orangemocha Sounds good! Currently we use the |
jBarz
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Nov 4, 2016
This is a minimal effort to support test output written both to stdout and file in order to get our buildbots understanding test output. Cherry picked from jbergstroem/node@3194073 Original commit message follows: PR-URL: nodejs/node#934 Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Conflicts: tools/test.py Reviewed-By: Julien Gilli <julien.gilli@joyent.com> PR-URL: nodejs#25653
jBarz
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Nov 4, 2016
On a few of our installations (namely CentOS), passing 'INFO' resulted in a silent loglevel. Use a logging constant instead. Cherry-picked from nodejs/node@8606793 Original commit metadata follows: Fixes: nodejs/build#104 PR-URL: nodejs/node#1842 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Julien Gilli <julien.gilli@joyent.com> PR-URL: nodejs#25653
jBarz
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Nov 4, 2016
Reviewed-By: Julien Gilli <julien.gilli@joyent.com> PR-URL: nodejs#25653
jBarz
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Nov 4, 2016
Adding support for specifying flaky test mode to the test runner: - via an environment variable FLAKY_TESTS for Makefile - via an argument ignore-flaky for vcbuild.bat Conflicts: Makefile Reviewed-By: Julien Gilli <julien.gilli@joyent.com> PR-URL: nodejs#25653
jBarz
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Nov 4, 2016
Make the test runner return a 0 exit code when only flaky tests fail and --flaky-tests=dontcare is specified. Reviewed-By: Julien Gilli <julien.gilli@joyent.com> PR-URL: nodejs#25653
jBarz
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Nov 4, 2016
Adding a single rule to be called from Jenkins. Reviewed-By: Julien Gilli <julien.gilli@joyent.com> PR-URL: nodejs#25653
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
..continued from #25541
As part of CI reconciliation, these commits make v0.12 work with the jobs at https://jenkins-iojs.nodesource.com/
This PR addresses all review feedback from #25541. In particular: