squash: fix race condition on closing fd

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
nodejs · May 15, 2022 · 11a5b35 · 11a5b35
1 parent f114cbb
commit 11a5b35
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/test/parallel/test-fs-read-position-validation.mjs b/test/parallel/test-fs-read-position-validation.mjs
@@ -20,7 +20,8 @@ async function testValid(position, allowedErrors = []) {
       const handler = common.mustCall((err) => {
         callCount--;
         if (err && !allowedErrors.includes(err.code)) {
-          fs.close(fd, common.mustSucceed(() => reject(err)));
+          fs.close(fd, common.mustSucceed());
+          reject(err);
         } else if (callCount === 0) {
           fs.close(fd, common.mustSucceed(resolve));
         }