Skip to content

Commit

Permalink
benchmark: move non-present deps down the list
Browse files Browse the repository at this point in the history
In previous version of this fix, I've simply added a check if the tested
tool is available or not. Unfortuntelly, this fails when only the first
tool is to be run as part of the test-benchmark-misc, and it doesn't
exist.

benchmark/test-benchmark-misc
...
AssertionError [ERR_ASSERTION]: benchmark file not running exactly one
configuration in test:
...
misc/startup-cli-version.js
...

The solution is to move the tool that is not present in a tarball down
the list.

Refs: #51146
  • Loading branch information
AdamMajer committed Feb 13, 2024
1 parent 544cfc5 commit 893ac74
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion benchmark/misc/startup-cli-version.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ const path = require('path');
// indispensible part of the CLI.
const bench = common.createBenchmark(main, {
cli: [
'tools/node_modules/eslint/bin/eslint.js',
'deps/npm/bin/npx-cli.js',
'deps/npm/bin/npm-cli.js',
'deps/corepack/dist/corepack.js',
'tools/node_modules/eslint/bin/eslint.js',
],
count: [30],
});
Expand Down

0 comments on commit 893ac74

Please sign in to comment.