Skip to content

Commit

Permalink
deps: remove usage of a C++20 feature from V8
Browse files Browse the repository at this point in the history
We are not ready to compile with C++20 support yet.
This is only a DCHECK that can be removed without affecting the behavior
of release builds.

PR-URL: #49639
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #52465
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
  • Loading branch information
targos authored and nodejs-github-bot committed Apr 22, 2024
1 parent 601c788 commit d4a9e7f
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.4',
'v8_embedder_string': '-node.5',

##### V8 defaults for Node.js #####

Expand Down
1 change: 0 additions & 1 deletion deps/v8/src/compiler/graph-visualizer.cc
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,6 @@ void JsonPrintAllSourceWithPositionsWasm(
os << "\"inlinings\": {";
for (size_t i = 0; i < positions.size(); ++i) {
if (i != 0) os << ", ";
DCHECK(source_map.contains(positions[i].inlinee_func_index));
size_t source_id = source_map.find(positions[i].inlinee_func_index)->second;
SourcePosition inlining_pos = positions[i].caller_pos;
os << '"' << i << "\": {\"inliningId\": " << i
Expand Down

0 comments on commit d4a9e7f

Please sign in to comment.