Skip to content

Commit

Permalink
test: assertion equality fix
Browse files Browse the repository at this point in the history
In test-net-write-callback.js, when process exits, we check callback
count against the expected value. The assertion is written with the
expected value first and actual value second, but that is the opposite
of the documented argument order. Reverse them to be consistent with
documentation.

PR-URL: #24422
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information
NoSkillGirl authored and Trott committed Nov 19, 2018
1 parent 738e076 commit dafd76c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/pummel/test-net-write-callbacks.js
Original file line number Diff line number Diff line change
Expand Up @@ -67,5 +67,5 @@ server.listen(common.PORT, function() {
});

process.on('exit', function() {
assert.strictEqual(N, cbcount);
assert.strictEqual(cbcount, N);
});

0 comments on commit dafd76c

Please sign in to comment.