benchmark: var to const

PR-URL: #13757
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

benchmark/_benchmark_progress.js

@@ -3,8 +3,8 @@
 const readline = require('readline');
 
 function pad(input, minLength, fill) {
-  var result = String(input);
-  var padding = fill.repeat(Math.max(0, minLength - result.length));
+  const result = String(input);
+  const padding = fill.repeat(Math.max(0, minLength - result.length));
   return `${padding}${result}`;
 }
 

benchmark/arrays/var-int.js

@@ -23,7 +23,7 @@ function main(conf) {
   const n = +conf.n;
 
   bench.start();
-  var arr = new clazz(n * 1e6);
+  const arr = new clazz(n * 1e6);
   for (var i = 0; i < 10; ++i) {
     run();
   }

benchmark/arrays/zero-float.js

@@ -23,7 +23,7 @@ function main(conf) {
   const n = +conf.n;
 
   bench.start();
-  var arr = new clazz(n * 1e6);
+  const arr = new clazz(n * 1e6);
   for (var i = 0; i < 10; ++i) {
     run();
   }

benchmark/arrays/zero-int.js

@@ -23,7 +23,7 @@ function main(conf) {
   const n = +conf.n;
 
   bench.start();
-  var arr = new clazz(n * 1e6);
+  const arr = new clazz(n * 1e6);
   for (var i = 0; i < 10; ++i) {
     run();
   }

benchmark/buffers/buffer-base64-encode.js

@@ -20,7 +20,7 @@
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
 'use strict';
-var common = require('../common.js');
+const common = require('../common.js');
 
 const bench = common.createBenchmark(main, {
   len: [64 * 1024 * 1024],

benchmark/buffers/buffer-bytelength.js

@@ -1,34 +1,34 @@
 'use strict';
-var common = require('../common');
+const common = require('../common');
 
-var bench = common.createBenchmark(main, {
+const bench = common.createBenchmark(main, {
   encoding: ['utf8', 'base64', 'buffer'],
   len: [1, 2, 4, 16, 64, 256], // x16
   n: [5e6]
 });
 
 // 16 chars each
-var chars = [
+const chars = [
   'hello brendan!!!', // 1 byte
   'ΰαβγδεζηθικλμνξο', // 2 bytes
   '挰挱挲挳挴挵挶挷挸挹挺挻挼挽挾挿', // 3 bytes
   '𠜎𠜱𠝹𠱓𠱸𠲖𠳏𠳕𠴕𠵼𠵿𠸎𠸏𠹷𠺝𠺢' // 4 bytes
 ];
 
 function main(conf) {
-  var n = conf.n | 0;
-  var len = conf.len | 0;
-  var encoding = conf.encoding;
+  const n = conf.n | 0;
+  const len = conf.len | 0;
+  const encoding = conf.encoding;
 
   var strings = [];
   var results;
   if (encoding === 'buffer') {
     strings = [ Buffer.alloc(len * 16, 'a') ];
     results = [ len * 16 ];
   } else {
-    for (var string of chars) {
+    for (const string of chars) {
       // Strings must be built differently, depending on encoding
-      var data = string.repeat(len);
+      const data = string.repeat(len);
       if (encoding === 'utf8') {
         strings.push(data);
       } else if (encoding === 'base64') {
@@ -45,9 +45,9 @@ function main(conf) {
 
   bench.start();
   for (var i = 0; i < n; i++) {
-    var index = n % strings.length;
+    const index = n % strings.length;
     // Go!
-    var r = Buffer.byteLength(strings[index], encoding);
+    const r = Buffer.byteLength(strings[index], encoding);
 
     if (r !== results[index])
       throw new Error('incorrect return value');

benchmark/buffers/buffer-compare.js

@@ -20,9 +20,9 @@
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
 'use strict';
-var common = require('../common.js');
+const common = require('../common.js');
 
-var bench = common.createBenchmark(main, {
+const bench = common.createBenchmark(main, {
   size: [16, 512, 1024, 4096, 16386],
   millions: [1]
 });

benchmark/buffers/buffer-indexof.js

@@ -1,6 +1,6 @@
 'use strict';
-var common = require('../common.js');
-var fs = require('fs');
+const common = require('../common.js');
+const fs = require('fs');
 const path = require('path');
 
 const searchStrings = [
@@ -21,15 +21,15 @@ const searchStrings = [
   '</i> to the Caterpillar'
 ];
 
-var bench = common.createBenchmark(main, {
+const bench = common.createBenchmark(main, {
   search: searchStrings,
   encoding: ['undefined', 'utf8', 'ucs2', 'binary'],
   type: ['buffer', 'string'],
   iter: [1]
 });
 
 function main(conf) {
-  var iter = (conf.iter) * 100000;
+  const iter = (conf.iter) * 100000;
   var aliceBuffer = fs.readFileSync(
     path.resolve(__dirname, '../fixtures/alice.html')
   );

benchmark/buffers/buffer-iterate.js

@@ -1,16 +1,16 @@
 'use strict';
-var SlowBuffer = require('buffer').SlowBuffer;
-var common = require('../common.js');
-var assert = require('assert');
+const SlowBuffer = require('buffer').SlowBuffer;
+const common = require('../common.js');
+const assert = require('assert');
 
-var bench = common.createBenchmark(main, {
+const bench = common.createBenchmark(main, {
   size: [16, 512, 1024, 4096, 16386],
   type: ['fast', 'slow'],
   method: ['for', 'forOf', 'iterator'],
   n: [1e3]
 });
 
-var methods = {
+const methods = {
   'for': benchFor,
   'forOf': benchForOf,
   'iterator': benchIterator
@@ -43,7 +43,7 @@ function benchForOf(buffer, n) {
   bench.start();
 
   for (var k = 0; k < n; k++) {
-    for (var b of buffer) {
+    for (const b of buffer) {
       assert(b === 0);
     }
   }
@@ -54,7 +54,7 @@ function benchIterator(buffer, n) {
   bench.start();
 
   for (var k = 0; k < n; k++) {
-    var iter = buffer[Symbol.iterator]();
+    const iter = buffer[Symbol.iterator]();
     var cur = iter.next();
 
     while (!cur.done) {

benchmark/buffers/buffer-read.js

@@ -1,7 +1,7 @@
 'use strict';
-var common = require('../common.js');
+const common = require('../common.js');
 
-var types = [
+const types = [
   'UInt8',
   'UInt16LE',
   'UInt16BE',
@@ -18,7 +18,7 @@ var types = [
   'DoubleBE'
 ];
 
-var bench = common.createBenchmark(main, {
+const bench = common.createBenchmark(main, {
   noAssert: ['false', 'true'],
   buffer: ['fast', 'slow'],
   type: types,

benchmark/buffers/buffer-slice.js

@@ -1,18 +1,18 @@
 'use strict';
-var common = require('../common.js');
-var SlowBuffer = require('buffer').SlowBuffer;
+const common = require('../common.js');
+const SlowBuffer = require('buffer').SlowBuffer;
 
-var bench = common.createBenchmark(main, {
+const bench = common.createBenchmark(main, {
   type: ['fast', 'slow'],
   n: [1024]
 });
 
-var buf = Buffer.allocUnsafe(1024);
-var slowBuf = new SlowBuffer(1024);
+const buf = Buffer.allocUnsafe(1024);
+const slowBuf = new SlowBuffer(1024);
 
 function main(conf) {
-  var n = +conf.n;
-  var b = conf.type === 'fast' ? buf : slowBuf;
+  const n = +conf.n;
+  const b = conf.type === 'fast' ? buf : slowBuf;
   bench.start();
   for (var i = 0; i < n * 1024; i++) {
     b.slice(10, 256);

benchmark/buffers/buffer-tojson.js

@@ -8,8 +8,8 @@ const bench = common.createBenchmark(main, {
 });
 
 function main(conf) {
-  var n = +conf.n;
-  var buf = Buffer.allocUnsafe(+conf.len);
+  const n = +conf.n;
+  const buf = Buffer.allocUnsafe(+conf.len);
 
   bench.start();
   for (var i = 0; i < n; ++i)

benchmark/buffers/buffer-write.js

@@ -1,7 +1,7 @@
 'use strict';
-var common = require('../common.js');
+const common = require('../common.js');
 
-var types = [
+const types = [
   'UInt8',
   'UInt16LE',
   'UInt16BE',
@@ -18,7 +18,7 @@ var types = [
   'DoubleBE'
 ];
 
-var bench = common.createBenchmark(main, {
+const bench = common.createBenchmark(main, {
   noAssert: ['false', 'true'],
   buffer: ['fast', 'slow'],
   type: types,
@@ -32,7 +32,7 @@ const UINT8 = (INT8 * 2) + 1;
 const UINT16 = (INT16 * 2) + 1;
 const UINT32 = INT32;
 
-var mod = {
+const mod = {
   writeInt8: INT8,
   writeInt16BE: INT16,
   writeInt16LE: INT16,
@@ -60,8 +60,8 @@ function main(conf) {
 }
 
 function benchInt(buff, fn, len, noAssert) {
-  var m = mod[fn];
-  var testFunction = new Function('buff', `
+  const m = mod[fn];
+  const testFunction = new Function('buff', `
     for (var i = 0; i !== ${len}; i++) {
       buff.${fn}(i & ${m}, 0, ${JSON.stringify(noAssert)});
     }
@@ -72,7 +72,7 @@ function benchInt(buff, fn, len, noAssert) {
 }
 
 function benchFloat(buff, fn, len, noAssert) {
-  var testFunction = new Function('buff', `
+  const testFunction = new Function('buff', `
     for (var i = 0; i !== ${len}; i++) {
       buff.${fn}(i, 0, ${JSON.stringify(noAssert)});
     }

benchmark/buffers/buffer_zero.js

@@ -11,7 +11,7 @@ const zeroBuffer = Buffer.alloc(0);
 const zeroString = '';
 
 function main(conf) {
-  var n = +conf.n;
+  const n = +conf.n;
   bench.start();
 
   if (conf.type === 'buffer')

benchmark/buffers/dataview-set.js

@@ -1,7 +1,7 @@
 'use strict';
-var common = require('../common.js');
+const common = require('../common.js');
 
-var types = [
+const types = [
   'Uint8',
   'Uint16LE',
   'Uint16BE',
@@ -18,7 +18,7 @@ var types = [
   'Float64BE'
 ];
 
-var bench = common.createBenchmark(main, {
+const bench = common.createBenchmark(main, {
   type: types,
   millions: [1]
 });
@@ -30,7 +30,7 @@ const UINT8 = INT8 * 2;
 const UINT16 = INT16 * 2;
 const UINT32 = INT32 * 2;
 
-var mod = {
+const mod = {
   setInt8: INT8,
   setInt16: INT16,
   setInt32: INT32,

benchmark/child_process/child-process-exec-stdout.js

@@ -3,7 +3,7 @@ const common = require('../common.js');
 const { exec, execSync } = require('child_process');
 const isWindows = process.platform === 'win32';
 
-var messagesLength = [64, 256, 1024, 4096];
+const messagesLength = [64, 256, 1024, 4096];
 // Windows does not support command lines longer than 8191 characters
 if (!isWindows) messagesLength.push(32768);
 

benchmark/child_process/child-process-read.js

@@ -7,7 +7,7 @@ const common = require('../common.js');
 const os = require('os');
 const child_process = require('child_process');
 
-var messagesLength = [64, 256, 1024, 4096];
+const messagesLength = [64, 256, 1024, 4096];
 // Windows does not support that long arguments
 if (os.platform() !== 'win32')
   messagesLength.push(32768);

benchmark/child_process/spawn-echo.js

@@ -1,12 +1,12 @@
 'use strict';
-var common = require('../common.js');
-var bench = common.createBenchmark(main, {
+const common = require('../common.js');
+const bench = common.createBenchmark(main, {
   n: [1000]
 });
 
-var spawn = require('child_process').spawn;
+const spawn = require('child_process').spawn;
 function main(conf) {
-  var n = +conf.n;
+  const n = +conf.n;
 
   bench.start();
   go(n, n);
@@ -16,7 +16,7 @@ function go(n, left) {
   if (--left === 0)
     return bench.end(n);
 
-  var child = spawn('echo', ['hello']);
+  const child = spawn('echo', ['hello']);
   child.on('exit', function(code) {
     if (code)
       process.exit(code);

benchmark/cluster/echo.js

@@ -11,10 +11,10 @@ if (cluster.isMaster) {
   });
 
   function main(conf) {
-    var n = +conf.n;
-    var workers = +conf.workers;
-    var sends = +conf.sendsPerBroadcast;
-    var expectedPerBroadcast = sends * workers;
+    const n = +conf.n;
+    const workers = +conf.workers;
+    const sends = +conf.sendsPerBroadcast;
+    const expectedPerBroadcast = sends * workers;
     var payload;
     var readies = 0;
     var broadcasts = 0;