Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent ARM test failures: test-fs-readfile{sync}-pipe-large #2261

Closed
Fishrock123 opened this issue Jul 28, 2015 · 4 comments
Closed

Consistent ARM test failures: test-fs-readfile{sync}-pipe-large #2261

Fishrock123 opened this issue Jul 28, 2015 · 4 comments
Labels
arm Issues and PRs related to the ARM platform. test Issues and PRs related to the tests.

Comments

@Fishrock123
Copy link
Contributor

Been consistently getting these on the ARM CI machines (pi1 and pi2):

https://jenkins-iojs.nodesource.com/job/iojs+pr+arm/189/nodes=pi1-raspbian-wheezy/tapTestReport/test.tap-242/

not ok 242 - test-fs-readfile-pipe-large.js
# { [Error: Command failed: /bin/sh -c cat /home/iojs/build/workspace/iojs+pr+arm/nodes/pi1-raspbian-wheezy/test/tmp.0/readfile_pipe_large_test.txt | "/home/iojs/build/workspace/iojs+pr+arm/nodes/pi1-raspbian-wheezy/out/Release/iojs" "/home/iojs/build/workspace/iojs+pr+arm/nodes/pi1-raspbian-wheezy/test/parallel/test-fs-readfile-pipe-large.js" child
# /home/iojs/build/workspace/iojs+pr+arm/nodes/pi1-raspbian-wheezy/test/common.js:34
# throw e;
# ^
# Error: ENOTEMPTY: directory not empty, rmdir '/home/iojs/build/workspace/iojs+pr+arm/nodes/pi1-raspbian-wheezy/test/tmp.0'
# at Error (native)
# at Object.fs.rmdirSync (fs.js:763:18)
# at rmdirSync (/home/iojs/build/workspace/iojs+pr+arm/nodes/pi1-raspbian-wheezy/test/common.js:49:10)
# at rimrafSync (/home/iojs/build/workspace/iojs+pr+arm/nodes/pi1-raspbian-wheezy/test/common.js:25:7)
# at Object.exports.refreshTmpDir (/home/iojs/build/workspace/iojs+pr+arm/nodes/pi1-raspbian-wheezy/test/common.js:55:3)
# at Object.<anonymous> (/home/iojs/build/workspace/iojs+pr+arm/nodes/pi1-raspbian-wheezy/test/parallel/test-fs-readfile-pipe-large.js:17:8)
# at Module._compile (module.js:430:26)
# at Object.Module._extensions..js (module.js:448:10)
# at Module.load (module.js:355:32)
# at Function.Module._load (module.js:310:12)
# cat: write error: Broken pipe
# ]
# killed: false,
# code: 1,
# signal: null,
# cmd: '/bin/sh -c cat /home/iojs/build/workspace/iojs+pr+arm/nodes/pi1-raspbian-wheezy/test/tmp.0/readfile_pipe_large_test.txt | "/home/iojs/build/workspace/iojs+pr+arm/nodes/pi1-raspbian-wheezy/out/Release/iojs" "/home/iojs/build/workspace/iojs+pr+arm/nodes/pi1-raspbian-wheezy/test/parallel/test-fs-readfile-pipe-large.js" child' }
# 
# assert.js:89
# throw new assert.AssertionError({
# ^
# AssertionError: it exits normally
# at /home/iojs/build/workspace/iojs+pr+arm/nodes/pi1-raspbian-wheezy/test/parallel/test-fs-readfile-pipe-large.js:34:3
# at ChildProcess.exithandler (child_process.js:204:5)
# at emitTwo (events.js:87:13)
# at ChildProcess.emit (events.js:172:7)
# at maybeClose (internal/child_process.js:764:16)
# at Socket.<anonymous> (internal/child_process.js:319:11)
# at emitOne (events.js:77:13)
# at Socket.emit (events.js:169:7)
# at Pipe._onclose (net.js:468:12)

https://jenkins-iojs.nodesource.com/job/iojs+pr+arm/189/nodes=pi1-raspbian-wheezy/tapTestReport/test.tap-245/

not ok 245 - test-fs-readfilesync-pipe-large.js
# { [Error: Command failed: /bin/sh -c cat /home/iojs/build/workspace/iojs+pr+arm/nodes/pi1-raspbian-wheezy/test/tmp.0/readfilesync_pipe_large_test.txt | "/home/iojs/build/workspace/iojs+pr+arm/nodes/pi1-raspbian-wheezy/out/Release/iojs" "/home/iojs/build/workspace/iojs+pr+arm/nodes/pi1-raspbian-wheezy/test/parallel/test-fs-readfilesync-pipe-large.js" child
# /home/iojs/build/workspace/iojs+pr+arm/nodes/pi1-raspbian-wheezy/test/common.js:34
# throw e;
# ^
# Error: ENOTEMPTY: directory not empty, rmdir '/home/iojs/build/workspace/iojs+pr+arm/nodes/pi1-raspbian-wheezy/test/tmp.0'
# at Error (native)
# at Object.fs.rmdirSync (fs.js:763:18)
# at rmdirSync (/home/iojs/build/workspace/iojs+pr+arm/nodes/pi1-raspbian-wheezy/test/common.js:49:10)
# at rimrafSync (/home/iojs/build/workspace/iojs+pr+arm/nodes/pi1-raspbian-wheezy/test/common.js:25:7)
# at Object.exports.refreshTmpDir (/home/iojs/build/workspace/iojs+pr+arm/nodes/pi1-raspbian-wheezy/test/common.js:55:3)
# at Object.<anonymous> (/home/iojs/build/workspace/iojs+pr+arm/nodes/pi1-raspbian-wheezy/test/parallel/test-fs-readfilesync-pipe-large.js:17:8)
# at Module._compile (module.js:430:26)
# at Object.Module._extensions..js (module.js:448:10)
# at Module.load (module.js:355:32)
# at Function.Module._load (module.js:310:12)
# cat: write error: Broken pipe
# ]
# killed: false,
# code: 1,
# signal: null,
# cmd: '/bin/sh -c cat /home/iojs/build/workspace/iojs+pr+arm/nodes/pi1-raspbian-wheezy/test/tmp.0/readfilesync_pipe_large_test.txt | "/home/iojs/build/workspace/iojs+pr+arm/nodes/pi1-raspbian-wheezy/out/Release/iojs" "/home/iojs/build/workspace/iojs+pr+arm/nodes/pi1-raspbian-wheezy/test/parallel/test-fs-readfilesync-pipe-large.js" child' }
# 
# assert.js:89
# throw new assert.AssertionError({
# ^
# AssertionError: it exits normally
# at /home/iojs/build/workspace/iojs+pr+arm/nodes/pi1-raspbian-wheezy/test/parallel/test-fs-readfilesync-pipe-large.js:31:3
# at ChildProcess.exithandler (child_process.js:204:5)
# at emitTwo (events.js:87:13)
# at ChildProcess.emit (events.js:172:7)
# at maybeClose (internal/child_process.js:764:16)
# at Socket.<anonymous> (internal/child_process.js:319:11)
# at emitOne (events.js:77:13)
# at Socket.emit (events.js:169:7)
# at Pipe._onclose (net.js:468:12)
@Fishrock123 Fishrock123 added test Issues and PRs related to the tests. arm Issues and PRs related to the ARM platform. labels Jul 28, 2015
@Fishrock123
Copy link
Contributor Author

cc @nodejs/platform-arm

@bnoordhuis
Copy link
Member

I think I know what's causing it. If https://jenkins-iojs.nodesource.com/job/iojs+pr+arm/192/ comes out green, I'll file a pull request.

@bnoordhuis bnoordhuis mentioned this issue Jul 29, 2015
Merged
bnoordhuis added a commit to bnoordhuis/io.js that referenced this issue Jul 29, 2015
@bnoordhuis
test: fix fs.readFile('/dev/stdin') tests
bc733f7 
The tests were creating the temp fixture file in both the parent
and the child process, leading to interesting race conditions on
the slower buildbots.

Rod notes that the tests started failing after putting the build
directory on a NFS mount.

Fixes: nodejs#2261
PR-URL: nodejs#2265
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
@thefourtheye
Copy link
Contributor

Can this be closed now?

@cjihrig
Copy link
Contributor

cjihrig commented Jul 29, 2015

Yes, closed by bc733f7.

@cjihrig cjihrig closed this as completed Jul 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arm Issues and PRs related to the ARM platform. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bnoordhuis @thefourtheye @Fishrock123 @cjihrig