Investigate flaky test - test-net-throttle #40507

mhdawson · 2021-10-18T21:48:37Z

Test: pummel/test-net-throttle
Platform: freebsd
Console Output:

node:assert:123
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:

false !== true

    at process.<anonymous> (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd12-x64/test/pummel/test-net-throttle.js:87:10)
    at process.emit (node:events:402:35) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: false,
  expected: true,
  operator: 'strictEqual'
}

Node.js v17.0.0-pre

Build Links:
https://ci.nodejs.org/job/node-test-commit-freebsd/nodes=freebsd12-x64/41547/testReport/junit/(root)/test/pummel_test_net_throttle/

The text was updated successfully, but these errors were encountered:

Sometimes the test completes with only two data chunks received on the client. Fixes: nodejs#40507

Sometimes the test completes with only two data chunks received on the client. Fixes: #40507 PR-URL: #48599 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>

The test is not very resource intensive. It just writes data to a TCP socket until backpressure is reached. Move it parallel. PR-URL: #48599 Fixes: #40507 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>

Sometimes the test completes with only two data chunks received on the client. Fixes: #40507 PR-URL: #48599 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>

The test is not very resource intensive. It just writes data to a TCP socket until backpressure is reached. Move it parallel. PR-URL: nodejs#48599 Fixes: nodejs#40507 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>

Sometimes the test completes with only two data chunks received on the client. Fixes: nodejs#40507 PR-URL: nodejs#48599 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>