Test runner: top-level diagnostics are ommited when running with --test

[MoLow]

Version

v20.0.0-pre

Platform

Darwin Moshes-MBP.localdomain 21.1.0 Darwin Kernel Version 21.1.0: Wed Oct 13 17:33:01 PDT 2021; root:xnu-8019.41.5~1/RELEASE_ARM64_T6000 arm64

Subsystem

test_runner

What steps will reproduce the bug?

run node --test test.js
where tets.js is

const test = require('node:test');
test(() => setImmediate(() => done()));

How often does it reproduce? Is there a required condition?

always

What is the expected behavior?

the same as when running without --test:

TAP version 13
# Subtest: <anonymous>
ok 1 - <anonymous>
  ---
  duration_ms: 2.272166
  ...
1..1
# Warning: Test "<anonymous>" generated asynchronous activity after the test ended. This activity created the error "ReferenceError: done is not defined" and would have caused the test to fail, but instead triggered an uncaughtException event.
# tests 1
# pass 1
# fail 0
# cancelled 0
# skipped 0
# todo 0
# duration_ms 5.046833

What do you see instead?

TAP version 13
# Subtest: /Users/moshe/repos/node/a.js
    # Subtest: <anonymous>
    ok 1 - <anonymous>
      ---
      duration_ms: 2.224708
      ...
    1..1
not ok 1 - /Users/moshe/repos/node/a.js
  ---
  duration_ms: 81.555291
  failureType: 'subtestsFailed'
  exitCode: 1
  error: 'test failed'
  code: 'ERR_TEST_FAILURE'
  ...
1..1
# tests 1
# pass 0
# fail 1
# cancelled 0
# skipped 0
# todo 0
# duration_ms 82.435834

missing # Warning: Test "<anonymous>" generated asynchronous activity after the test ended. This activity created the error "ReferenceError: done is not defined" and would have caused the test to fail, but instead triggered an uncaughtException event.

Additional information

diagnostics were ignored intentionally so the duration_ms, tests, pass etc don't appear twice:

node/lib/internal/test_runner/runner.js

Lines 184 to 187 in f14fa1b

	if (nesting === 1) {
	// Ignore file top level diagnostics
	break;
	}

we should find some way to filter top-level diagnostics only in cases they are redundant

[cjihrig]

cc @manekinekko

[MoLow]

I initially thought this and #45911 were the same issue but some debugging showed that #45911 originates inside the TAP parser whereas this issue comes from here

node/lib/internal/test_runner/runner.js

Lines 184 to 187 in f14fa1b

	if (nesting === 1) {
	// Ignore file top level diagnostics
	break;
	}

[manekinekko]

For anyone looking to work on this issue, I've commented on #45911. Both issues are related.

#45911 (comment)

[Ayush-Dutt-Sharma]

@MoLow claim

[ashutosh887]

Hi @manekinekko

I would like to work on this Issue!

[cjihrig]

@ashutosh887 I noticed that you commented on at least 3 issues that you would like to work on them. Feel free to work on any available issues, but please do not try to "claim" them or otherwise lick the cookie. That creates problems in the event that you aren't able to complete everything you've signed up for.

[MrJithil]

Please feel free to work on it. I closed the one I created as it's not the way we needed.

[ashutosh887]

@cjihrig No it's not like that
I'm really willing to contribute but finding hard to get started

[italojs]

@ashutosh887 are you still interested to take it? what is your main difficulty? we could try to help you

@MoLow if @ashutosh887 does not reply, I'm the next in the queue to work on this ;)

[MoLow]

@italojs AFAIAC you can work on this

[italojs]

nice, could you assign it to me, please?

[MoLow]

@italojs no need to assign, you can simply go ahead and create a PR