Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parallel/test-fs-read-stream-concurrent-reads is flaky #51862

Open
joyeecheung opened this issue Feb 23, 2024 · 4 comments
Open

parallel/test-fs-read-stream-concurrent-reads is flaky #51862

joyeecheung opened this issue Feb 23, 2024 · 4 comments
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.

Comments

@joyeecheung
Copy link
Member

Reason parallel/test-fs-read-stream-concurrent-reads
Type JS_TEST_FAILURE
Failed PR 3 (https://github.com/nodejs/node/pull/51687/, https://github.com/nodejs/node/pull/51810/, https://github.com/nodejs/node/pull/51623/)
Appeared test-digitalocean-fedora38-x64-2, test-digitalocean-fedora38-x64-1, test-osuosl-debian11_container-armv7l-1
First CI https://ci.nodejs.org/job/node-test-pull-request/57233/
Last CI https://ci.nodejs.org/job/node-test-pull-request/57292/
Example 
not ok 1433 parallel/test-fs-read-stream-concurrent-reads
  ---
  duration_ms: 120105.09600
  severity: fail
  exitcode: -15
  stack: |-
    timeout
  ...

Refs: nodejs/reliability#791
@joyeecheung joyeecheung added flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests. labels Feb 23, 2024
@mhdawson
Copy link
Member

Again - https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubuntu2204_sharedlibs_withoutssl_x64/42216/

@targos
Copy link
Member

targos commented Apr 16, 2024

It's still very flaky: nodejs/reliability#835

@mhdawson
Copy link
Member

Again - https://ci.nodejs.org/job/node-test-commit-linux/nodes=fedora-latest-x64/57391/

mhdawson added a commit to mhdawson/io.js that referenced this issue Apr 24, 2024
@mhdawson
test: mark test as flaky
ff76171 
Refs: nodejs#51862

Ran into this a few times myself this week and also
seems to be a top failer in the reliability reports

Signed-off-by: Michael Dawson <midawson@redhat.com>
@mhdawson mhdawson mentioned this issue Apr 24, 2024
Merged
nodejs-github-bot pushed a commit that referenced this issue Apr 26, 2024
@mhdawson
test: mark test as flaky
02388eb 
Refs: #51862

Ran into this a few times myself this week and also
seems to be a top failer in the reliability reports

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: #52671
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
aduh95 pushed a commit that referenced this issue Apr 29, 2024
@mhdawson @aduh95
test: mark test as flaky
45f7002 
Refs: #51862

Ran into this a few times myself this week and also
seems to be a top failer in the reliability reports

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: #52671
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
marco-ippolito pushed a commit that referenced this issue May 2, 2024
@mhdawson @marco-ippolito
test: mark test as flaky
466ba4b 
Refs: #51862

Ran into this a few times myself this week and also
seems to be a top failer in the reliability reports

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: #52671
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
marco-ippolito pushed a commit that referenced this issue May 3, 2024
@mhdawson @marco-ippolito
test: mark test as flaky
d4f1803 
Refs: #51862

Ran into this a few times myself this week and also
seems to be a top failer in the reliability reports

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: #52671
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
eliiphaz pushed a commit to eliiphaz/node that referenced this issue Jun 20, 2024
@mhdawson @eliiphaz
test: mark test as flaky
98aa3f1 
Refs: nodejs#51862

Ran into this a few times myself this week and also
seems to be a top failer in the reliability reports

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: nodejs#52671
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
bmeck pushed a commit to bmeck/node that referenced this issue Jun 22, 2024
@mhdawson @bmeck
test: mark test as flaky
fa62f87 
Refs: nodejs#51862

Ran into this a few times myself this week and also
seems to be a top failer in the reliability reports

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: nodejs#52671
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@jasnell
Copy link
Member

jasnell commented Sep 7, 2024

@addaleax @gireeshpunathil ... do either of you remember why test-fs-read-stream-concurrent-reads.js was written to require 2000 streams? Based on the test it's not clear that so many iterations are required and the test is flaky. I'm think we either should reduce the number of iterations or maybe move the test to sequential --- I'm wondering if the concurrent reads and allocations may be causing the timeout errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jasnell @targos @joyeecheung @mhdawson