n.kill(19) throws error

[ORESoftware]

On versions 6 and 7 of Node.js

when I started a child process with const n = require('child_process').spawn

if I try,

n.kill(19), I get an error saying the signal is not recognized

but 19 is a valid signal
http://stackoverflow.com/questions/9951556/why-number-9-in-kill-9-command-in-unix

I would expect it to work

if I do n.kill('SIGSTOP'), it seems to work.

Can we (not) use numbers/integers with n.kill()?

[Fishrock123]

Can we (not) use numbers/integers with n.kill()?

That is my (perhaps poor) understanding.

[cjihrig]

Again, can you please ask these general support questions at https://github.com/nodejs/help.

[sam-github]

This is a doc bug (besides being an implied reasonable feature request):

• https://nodejs.org/api/process.html#process_process_kill_pid_signal says it supports <String> | <number>, but actually, it only supports one number, 0, the special value to test if the target pid exists, but any reasonable reading of the docs would assume any valid signal number was supported
• https://nodejs.org/api/child_process.html#child_process_child_kill_signal says it supports only <string>, but its a thin wrapper around process.kill(), it will also support 0, a number.

[sam-github]

@ORESoftware use strings for now, or use process._kill() if you are desperate, its not an official API, though, and may disappear at any time.

[ORESoftware]

@cjihrig yeah np, this seemed like a more serious one though. Seems like it would be very easy to support numbers as well as strings, very unexpected.

[cjihrig]

@ORESoftware apologies. It looks like you had a valid bug report.

[sam-github]

@ORESoftware any interest in PRing numeric signal support? And/or the doc fixes? I'll be able to review or merge, but I won't have time to implement this week, someone else may pick them up, but if you have time and interest in contributing to the project, these are good first contributions.

[ORESoftware]

Yeah I could give that a shot

On Nov 9, 2016 11:06 AM, "Sam Roberts" notifications@github.com wrote:

@ORESoftware https://github.com/ORESoftware any interest in PRing
numeric signal support? And/or the doc fixes? I'll be able to review or
merge, but I won't have time to implement this week, someone else may pick
them up, but if you have time and interest in contributing to the project,
these are good first contributions.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#9519 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AKn56O-GR_5bHi6UZ9nk5GggTp3856amks5q8hmogaJpZM4Ks5Tp
.

[gerrard00]

I don't mean to step on any toes, but I took a cut at this. I've been looking for something to get my feet wet and this seemed easy enough. Your feedback is greatly appreciated.

#9651

[Trott]

@sam-github Should this stay open?

[richardlau]

I think this is fixed by #10423