Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: update cluster test #10042

Closed
wants to merge 1 commit into from
Closed

test: update cluster test #10042

wants to merge 1 commit into from

Conversation

bidurbabu
Copy link

@bidurbabu bidurbabu commented Dec 1, 2016 •
edited
Loading

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

Test

Description of change

Updated test-cluster-shared-handle-bind-privileged-port test
method to use assert.strictEqual() instead of assert.equal()

@badhikari-godaddy
test: update cluster test
fe02268 
Updated test-cluster-shared-handle-bind-privileged-port test
method to use assert.strictEqual() instead of assert.equal()
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@imyller imyller added cluster Issues and PRs related to the cluster subsystem. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. labels Dec 1, 2016
@Trott
Copy link
Member

Trott commented Dec 4, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/5160/

@Trott
Copy link
Member

Trott commented Dec 4, 2016

Failure in CI is infrastructure-related.

Trott pushed a commit to Trott/io.js that referenced this pull request Dec 4, 2016
@badhikari-godaddy @Trott
test: use assert.strictEqual() cluster test
4a63fa3 
Updated test-cluster-shared-handle-bind-privileged-port test
method to use assert.strictEqual() instead of assert.equal()

PR-URL: nodejs#10042
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@Trott
Copy link
Member

Trott commented Dec 4, 2016

Landed in 4a63fa3

@Trott Trott closed this Dec 4, 2016
@Trott
Copy link
Member

Trott commented Dec 4, 2016

Thanks for the contribution! 🎉

addaleax pushed a commit that referenced this pull request Dec 5, 2016
@badhikari-godaddy @addaleax
test: use assert.strictEqual() cluster test
f9d79ef 
Updated test-cluster-shared-handle-bind-privileged-port test
method to use assert.strictEqual() instead of assert.equal()

PR-URL: #10042
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@Fishrock123 Fishrock123 mentioned this pull request Dec 5, 2016
Merged
2 tasks
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
@badhikari-godaddy @addaleax
test: use assert.strictEqual() cluster test
a36389e 
Updated test-cluster-shared-handle-bind-privileged-port test
method to use assert.strictEqual() instead of assert.equal()

PR-URL: nodejs#10042
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
@badhikari-godaddy
test: use assert.strictEqual() cluster test
ac175e1 
Updated test-cluster-shared-handle-bind-privileged-port test
method to use assert.strictEqual() instead of assert.equal()

PR-URL: nodejs#10042
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
@badhikari-godaddy @MylesBorins
test: use assert.strictEqual() cluster test
27c9171 
Updated test-cluster-shared-handle-bind-privileged-port test
method to use assert.strictEqual() instead of assert.equal()

PR-URL: #10042
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@badhikari-godaddy @MylesBorins
test: use assert.strictEqual() cluster test
f1d395c 
Updated test-cluster-shared-handle-bind-privileged-port test
method to use assert.strictEqual() instead of assert.equal()

PR-URL: #10042
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@badhikari-godaddy @MylesBorins
test: use assert.strictEqual() cluster test
c569055 
Updated test-cluster-shared-handle-bind-privileged-port test
method to use assert.strictEqual() instead of assert.equal()

PR-URL: #10042
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
This was referenced Dec 21, 2016
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@santigimeno santigimeno santigimeno approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
cluster Issues and PRs related to the cluster subsystem. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@bidurbabu @Trott @santigimeno @cjihrig @MylesBorins @addaleax @imyller @nodejs-github-bot @badhikari-godaddy