Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dns: minor refactor of dns module #11597

Closed
wants to merge 1 commit into from
Closed

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Feb 28, 2017

Move to the more efficient module.exports = {} pattern.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

dns

@nodejs-github-bot nodejs-github-bot added the dns Issues and PRs related to the dns subsystem. label Feb 28, 2017
@claudiorodriguez
Copy link
Contributor

Move to the more efficient module.exports = {} pattern.
@jasnell
Copy link
Member Author

jasnell commented Mar 4, 2017

New CI after rebasing https://ci.nodejs.org/job/node-test-pull-request/6706/

jasnell added a commit that referenced this pull request Mar 4, 2017
Move to the more efficient module.exports = {} pattern.

PR-URL: #11597
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@jasnell
Copy link
Member Author

jasnell commented Mar 4, 2017

Landed in 531de63

@jasnell jasnell closed this Mar 4, 2017
addaleax pushed a commit that referenced this pull request Mar 5, 2017
Move to the more efficient module.exports = {} pattern.

PR-URL: #11597
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@evanlucas evanlucas mentioned this pull request Mar 8, 2017
@MylesBorins
Copy link
Contributor

This doesn't land cleanly,
This does not land cleanly in LTS. Please feel free to manually backport. Please also feel free to replace the backport request label with do-not-land if it shouldn't land

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dns Issues and PRs related to the dns subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants