Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add coverage for child_process bounds check #11800

Closed
wants to merge 3 commits into from
Closed

test: add coverage for child_process bounds check #11800

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bf8a998
test: add coverage for child_process bounds check
Trott Mar 11, 2017
c2a2dc2
squash: hopeful fix for Windows
Trott Mar 14, 2017
f28a356
squash: make it one line and see if that fixes it on Windows
Trott Mar 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: add coverage for child_process bounds check 
Make sure that monkey-patching process.execArgv doesn't cause
child_process to incorrectly munge execArgv in fork().

This basically is adding coverage for an `index > 0` check (see Refs).
Previously, that condition was never false in any of the tests.

Refs: https://github.com/nodejs/node/blob/c67207731f16a78f6cae90e49c53b10728241ecf/lib/child_process.js#L76
  • Loading branch information
@Trott
Trott committed Mar 17, 2017
commit bf8a9986e8edf433f215a73af28a2635d05df33f
11 changes: 11 additions & 0 deletions test/parallel/test-cli-eval.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,17 @@ child.exec(`${nodejs} --use-strict -p process.execArgv`,
assert.strictEqual(stdout, '');
assert.strictEqual(stderr, '');
}));

// Make sure that monkey-patching process.execArgv doesn't cause child_process
// to incorrectly munge execArgv.
child.exec(
`${nodejs} -e 'process.execArgv = ["-e", "console.log(42)", "thirdArg"];
require("child_process").fork("${emptyFile}")'`,
common.mustCall((err, stdout, stderr) => {
assert.ifError(err);
assert.strictEqual(stdout, '42\n');
assert.strictEqual(stderr, '');
}));
}

// Regression test for https://github.com/nodejs/node/issues/8534.
Expand Down