Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve test coverage for n-api #12327

Closed
wants to merge 2 commits into from
Closed

Conversation

mhdawson
Copy link
Member

Add basic tests for handle scopes as code coverage
reports that we are not covering these with the existing
tests.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows [commit guidelines]
Affected core subsystem(s)

test, n-api

Add basic tests for handle scopes as code coverage
reports that we are not covering these with the existing
tests.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 11, 2017
@mscdex mscdex added the node-api Issues and PRs related to the Node-API. label Apr 11, 2017
const assert = require('assert');

// testing handle scope api calls
const test_handle_scope =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use camelCase in the JS code.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure just copied other existing test as a base, but that's not a good reason :). Updating

@mhdawson
Copy link
Member Author

Pushed commit to address switch to camel case in js.

@mhdawson
Copy link
Member Author

@mhdawson
Copy link
Member Author

Landed as 0ec0272

@mhdawson mhdawson closed this Apr 12, 2017
mhdawson added a commit that referenced this pull request Apr 12, 2017
Add basic tests for handle scopes as code coverage
reports that we are not covering these with the existing
tests.

PR-URL: #12327
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell jasnell mentioned this pull request May 11, 2017
@mhdawson mhdawson deleted the napi-cov1 branch June 28, 2017 19:24
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 10, 2018
Add basic tests for handle scopes as code coverage
reports that we are not covering these with the existing
tests.

PR-URL: nodejs#12327
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 16, 2018
Add basic tests for handle scopes as code coverage
reports that we are not covering these with the existing
tests.

Backport-PR-URL: #19447
PR-URL: #12327
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants