test: allow for absent nobody user in setuid test #13112
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some isolated build or test VMs don't have a "nobody" user, causing the parallel/test-process-setuid-setgid test to fail. Add logic to allow for that situation. Fixes: nodejs#13071
Trott
added
addons
|
This only fixes it for when the test is not run as super user, but the other pre-existing special logic for non-existent nobody GID also only applies to non-super user runs. Dealing with missing Either way, this PR is still an improvement. |
|
@Qantas94Heavy Can you confirm that this change makes the test pass in your environment? |
|
@Trott yes, this patch fixes the issue. 👍 |
gireeshpunathil
approved these changes
May 19, 2017
gibfahn
approved these changes
May 19, 2017
cjihrig
approved these changes
May 19, 2017
lpinca
approved these changes
May 20, 2017
Trott
added a commit
to Trott/io.js
that referenced
this pull request
May 22, 2017
Some isolated build or test VMs don't have a "nobody" user, causing the parallel/test-process-setuid-setgid test to fail. Add logic to allow for that situation. PR-URL: nodejs#13112 Fixes: nodejs#13071 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
Landed in 8e47600 |
jasnell
pushed a commit
that referenced
this pull request
May 23, 2017
Some isolated build or test VMs don't have a "nobody" user, causing the parallel/test-process-setuid-setgid test to fail. Add logic to allow for that situation. PR-URL: #13112 Fixes: #13071 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
May 23, 2017
Some isolated build or test VMs don't have a "nobody" user, causing the parallel/test-process-setuid-setgid test to fail. Add logic to allow for that situation. PR-URL: #13112 Fixes: #13071 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
3 tasks
MylesBorins
pushed a commit
that referenced
this pull request
Jul 17, 2017
Some isolated build or test VMs don't have a "nobody" user, causing the parallel/test-process-setuid-setgid test to fail. Add logic to allow for that situation. PR-URL: #13112 Fixes: #13071 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some isolated build or test VMs don't have a "nobody" user, causing the
parallel/test-process-setuid-setgid test to fail. Add logic to allow for
that situation.
Fixes: #13071
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test process