doc: update who to cc for async_hooks #13332
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that `async_hooks` is released, it makes sense to me to have a team for addressing issues with it. nodejs/diagnostics can still be @mentioned if there are questions about the API rather than its implementation.
gibfahn
approved these changes
May 31, 2017
mscdex
added
async_hooks
|
Sure. The APM providers in @nodejs/diagnostics need to be informed of API changes/suggestions, but I think a subset is fine for bugs. |
AndreasMadsen
approved these changes
May 31, 2017
cjihrig
approved these changes
May 31, 2017
bnoordhuis
approved these changes
May 31, 2017
jasnell
approved these changes
May 31, 2017
trevnorris
approved these changes
May 31, 2017
|
Landed in 9b9a25c |
addaleax
added a commit
that referenced
this pull request
Jun 3, 2017
Now that `async_hooks` is released, it makes sense to me to have a team for addressing issues with it. nodejs/diagnostics can still be @mentioned if there are questions about the API rather than its implementation. PR-URL: #13332 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Andreas Madsen <amwebdk@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
jasnell
pushed a commit
that referenced
this pull request
Jun 5, 2017
Now that `async_hooks` is released, it makes sense to me to have a team for addressing issues with it. nodejs/diagnostics can still be @mentioned if there are questions about the API rather than its implementation. PR-URL: #13332 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Andreas Madsen <amwebdk@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that
async_hooksis released, it makes sense to me to have a team for addressing issues with it. @nodejs/diagnostics can still be @mentioned if there are questions about the API rather than its implementation.@nodejs/diagnostics fyi – I know it was originally requested that you are the team to ping for this kind of thing, but I think for implementation issues it’s just easier to ping the subset that actually works on them. Anybody who wants to join @nodejs/async_hooks is welcome to do so!