Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8: add a js class for Serializer/Dserializer #13541

Closed
wants to merge 6 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
v8: add a js class for Serializer/Deserializer
Calling Serializer/Deserializer without new crashes node.
Adding a js class which just inherits cpp bindings.
Added regression tests.

Fixes: #13326
  • Loading branch information
zimbabao committed Jun 10, 2017
commit 1de429ce02a8334dd6ae3b5713133c950812d8a4
6 changes: 3 additions & 3 deletions lib/v8.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@

const { Buffer } = require('buffer');
const {
Serializer: _Serializer,
Deserializer: _Deserializer
} = process.binding('serdes');
Serializer: _Serializer,
Deserializer: _Deserializer
} = process.binding('serdes');
const { copy } = process.binding('buffer');
const { objectToString } = require('internal/util');
const { FastBuffer } = require('internal/buffer');
Expand Down