benchmark: fix some RegExp nits #13551
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
benchmark
vsemozhetbyt
removed
buffer
cjihrig
approved these changes
Jun 8, 2017
tniessen
reviewed
Jun 8, 2017
| // Parse configuration arguments | ||
| for (const arg of argv) { | ||
| const match = arg.match(/^(.+?)=([\s\S]*)$/); | ||
| const match = arg.match(validArgRE); |
There was a problem hiding this comment.
There is some match[capture_index] processing below.
refack
approved these changes
Jun 8, 2017
tniessen
approved these changes
Jun 8, 2017
lpinca
approved these changes
Jun 10, 2017
|
Landed in 8beff64 |
vsemozhetbyt
added a commit
that referenced
this pull request
Jun 12, 2017
* Take RegExp creation out of cycle. * use test(), not match() in boolean context. PR-URL: #13551 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Jun 12, 2017
* Take RegExp creation out of cycle. * use test(), not match() in boolean context. PR-URL: #13551 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
benchmark
RegExpinstance creation out of a cycle.test(), notmatch()in a boolean context.