improved assert message on cluster-worker-disconnect #16021
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BridgeAR
reviewed
Oct 6, 2017
| assert.strictEqual(w.voluntaryMode, true, | ||
| 'Voluntary exit mode was not set'); | ||
| 'Voluntary exit mode was not set, current voluntary mode is ${w.voluntaryMode}'); |
There was a problem hiding this comment.
The line length is to long. It would actually be best to just remove the message overall. The message from strictEqual should be better than the current situation. The same applies to w.state.
Trott
added
the
code-and-learn
|
ping @Hadis-Fard |
jasnell
reviewed
Oct 23, 2017
| @@ -58,7 +58,7 @@ if (cluster.isWorker) { | |||
| // Disconnect worker when it is ready | |||
| worker.once('listening', common.mustCall(() => { | |||
| const w = worker.disconnect(); | |||
| assert.strictEqual(worker, w, 'did not return a reference'); | |||
| assert.strictEqual(worker, w, '${worker.id} did not return a reference'); | |||
There was a problem hiding this comment.
nit: This needs backticks on the string literal rather than single quote marks.
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Oct 28, 2017
Improve assert messages in test-cluster-worker-disconnect.js. PR-URL: nodejs#16021 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
|
Landed in eefee3e. Thanks for the contribution! 🎉 |
gibfahn
pushed a commit
that referenced
this pull request
Oct 30, 2017
Improve assert messages in test-cluster-worker-disconnect.js. PR-URL: #16021 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
gibfahn
pushed a commit
that referenced
this pull request
Oct 30, 2017
Improve assert messages in test-cluster-worker-disconnect.js. PR-URL: #16021 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
gibfahn
pushed a commit
that referenced
this pull request
Oct 31, 2017
Improve assert messages in test-cluster-worker-disconnect.js. PR-URL: #16021 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
Qard
pushed a commit
to ayojs/ayo
that referenced
this pull request
Nov 2, 2017
Improve assert messages in test-cluster-worker-disconnect.js. PR-URL: nodejs/node#16021 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Qard
pushed a commit
to ayojs/ayo
that referenced
this pull request
Nov 2, 2017
Improve assert messages in test-cluster-worker-disconnect.js. PR-URL: nodejs/node#16021 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 16, 2017
Improve assert messages in test-cluster-worker-disconnect.js. PR-URL: #16021 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 21, 2017
Improve assert messages in test-cluster-worker-disconnect.js. PR-URL: #16021 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 28, 2017
Improve assert messages in test-cluster-worker-disconnect.js. PR-URL: #16021 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Dec 7, 2017
Improve assert messages in test-cluster-worker-disconnect.js. PR-URL: nodejs/node#16021 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)