Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AsyncWrap minor fixes #1614

Closed
wants to merge 4 commits into from
Closed

AsyncWrap minor fixes #1614

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3f51590
async-wrap: don't call init callback unnecessarily
trevnorris May 4, 2015
cc0385e
async-wrap: pass PROVIDER as first arg to init
trevnorris May 4, 2015
7740d5e
async-wrap: set flags using functions
trevnorris May 4, 2015
eed38b3
async-wrap: remove before/after calls in init
trevnorris May 4, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
async-wrap: pass PROVIDER as first arg to init 
Allow the init callback to see the PROVIDER type easily by being able to
compare the flag with the list of providers on the exported async_wrap
object.
  • Loading branch information
@trevnorris
trevnorris committed May 4, 2015
commit cc0385e022515bb99f67140c8b3c273b23d2cc1f
3 changes: 2 additions & 1 deletion src/async-wrap-inl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,8 @@ inline AsyncWrap::AsyncWrap(Environment* env,
FatalError("node::AsyncWrap::AsyncWrap", "parent pre hook threw");
}

env->async_hooks_init_function()->Call(object, 0, nullptr);
v8::Local<v8::Value> n = v8::Int32::New(env->isolate(), provider);
env->async_hooks_init_function()->Call(object, 1, &n);

if (try_catch.HasCaught())
FatalError("node::AsyncWrap::AsyncWrap", "init hook threw");
Expand Down