Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use countdown in test file #17874

Closed
wants to merge 1 commit into from
Closed

test: use countdown in test file #17874

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 6 additions & 20 deletions test/parallel/test-http-get-pipeline-problem.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ const fixtures = require('../common/fixtures');
const assert = require('assert');
const http = require('http');
const fs = require('fs');
const Countdown = require('../common/countdown');

http.globalAgent.maxSockets = 1;

Expand All @@ -38,14 +39,12 @@ const image = fixtures.readSync('/person.jpg');
console.log(`image.length = ${image.length}`);

const total = 10;
let requests = 0;
let responses = 0;
const responseCountdown = new Countdown(total, common.mustCall(() => {
checkFiles();
server.close();
}));

const server = http.Server(function(req, res) {
if (++requests === total) {
server.close();
}

setTimeout(function() {
res.writeHead(200, {
'content-type': 'image/jpeg',
Expand Down Expand Up @@ -74,9 +73,7 @@ server.listen(0, function() {

s.on('finish', function() {
console.error(`done ${x}`);
if (++responses === total) {
checkFiles();
}
responseCountdown.dec();
});
}).on('error', function(e) {
console.error('error! ', e.message);
Expand All @@ -86,8 +83,6 @@ server.listen(0, function() {
}
});


let checkedFiles = false;
function checkFiles() {
// Should see 1.jpg, 2.jpg, ..., 100.jpg in tmpDir
const files = fs.readdirSync(common.tmpDir);
Expand All @@ -101,13 +96,4 @@ function checkFiles() {
image.length, stat.size,
`size doesn't match on '${fn}'. Got ${stat.size} bytes`);
}

checkedFiles = true;
}


process.on('exit', function() {
assert.strictEqual(total, requests);
assert.strictEqual(total, responses);
assert.ok(checkedFiles);
});