Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix cctest -Wunused-variable warning #18530

Closed
wants to merge 1 commit into from
Closed

test: fix cctest -Wunused-variable warning #18530

wants to merge 1 commit into from

Conversation

bnoordhuis
Copy link
Member

No description provided.

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 2, 2018
cjihrig
cjihrig approved these changes Feb 2, 2018
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the CI is happy.

@joyeecheung
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/12917/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 3, 2018
@cjihrig cjihrig mentioned this pull request Feb 4, 2018
Closed
2 tasks
@danbev
Copy link
Contributor

danbev commented Feb 5, 2018

Landed in b9a873e.

@danbev danbev closed this Feb 5, 2018
danbev pushed a commit to danbev/node that referenced this pull request Feb 5, 2018
@bnoordhuis @danbev
test: fix cctest -Wunused-variable warning
b9a873e 
PR-URL: nodejs#18530
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@mmarchini mmarchini mentioned this pull request Feb 22, 2018
Closed
4 tasks
mmarchini pushed a commit to mmarchini/node that referenced this pull request Feb 26, 2018
@bnoordhuis
test: fix cctest -Wunused-variable warning
7d12ef6 
PR-URL: nodejs#18530
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
addaleax pushed a commit that referenced this pull request Feb 26, 2018
@bnoordhuis @addaleax
test: fix cctest -Wunused-variable warning
cfab1f5 
Backport-PR-URL: #18550
PR-URL: #18530
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 26, 2018
@bnoordhuis @MylesBorins
test: fix cctest -Wunused-variable warning
35cddae 
Backport-PR-URL: #18550
PR-URL: #18530
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@addaleax addaleax mentioned this pull request Feb 27, 2018
Closed
mmarchini pushed a commit to mmarchini/node that referenced this pull request Mar 6, 2018
@bnoordhuis
test: fix cctest -Wunused-variable warning
cd00e23 
PR-URL: nodejs#18530
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@mmarchini mmarchini mentioned this pull request Mar 6, 2018
Closed
4 tasks
mmarchini pushed a commit to mmarchini/node that referenced this pull request Mar 13, 2018
@bnoordhuis
test: fix cctest -Wunused-variable warning
3d1b6ef 
PR-URL: nodejs#18530
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@mmarchini mmarchini mentioned this pull request Mar 13, 2018
Closed
4 tasks
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@bnoordhuis @MayaLekova
test: fix cctest -Wunused-variable warning
500eca3 
PR-URL: nodejs#18530
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 22, 2018
@bnoordhuis @MylesBorins
test: fix cctest -Wunused-variable warning
3b8e2d0 
PR-URL: #18530
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 22, 2018
@bnoordhuis @MylesBorins
test: fix cctest -Wunused-variable warning
d27ca6d 
Backport-PR-URL: #19176
PR-URL: #18530
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jun 14, 2018
@bnoordhuis @MylesBorins
test: fix cctest -Wunused-variable warning
e0526a5 
Backport-PR-URL: #19176
PR-URL: #18530
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jul 9, 2018
Merged
rvagg pushed a commit that referenced this pull request Aug 16, 2018
@bnoordhuis @rvagg
test: fix cctest -Wunused-variable warning
b7564c4 
Backport-PR-URL: #19176
PR-URL: #18530
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danbev danbev danbev approved these changes

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@bnoordhuis @joyeecheung @danbev @jasnell @cjihrig @MylesBorins @addaleax @BridgeAR @nodejs-github-bot