test: formalize exposure of internal bindings #18698
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
|
cc @nodejs/testing |
joyeecheung
approved these changes
Feb 10, 2018
I would say if there is a test case that is hard to cover with only public APIs, then go for it, but at least add a description to the test documenting why it has to directly test the binding. |
TimothyGu
approved these changes
Feb 10, 2018
node.gyp
Outdated
| @@ -126,6 +125,7 @@ | |||
| 'lib/internal/repl/await.js', | |||
| 'lib/internal/socket_list.js', | |||
| 'lib/internal/test/unicode.js', | |||
| 'lib/internal/test/binding.js', | |||
moves exposed internalBindings to a single location with short guidelines on how to expose them and a warning for users should they come across it
BridgeAR
approved these changes
Feb 10, 2018
BridgeAR
added
the
author ready
devsnek
force-pushed
the
internal-test-binding
branch
from
f8111d4
to
0a70453
Compare
|
landed in 3e8af96 |
devsnek
added a commit
that referenced
this pull request
Feb 10, 2018
moves exposed internalBindings to a single location with short guidelines on how to expose them and a warning for users should they come across it PR-URL: #18698 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
|
Should this be backported to |
devsnek
removed
the
author ready
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
May 1, 2018
moves exposed internalBindings to a single location with short guidelines on how to expose them and a warning for users should they come across it PR-URL: nodejs#18698 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
moves exposed internalBindings to a single location with short guidelines on how to expose them and a warning for users should they come across it PR-URL: nodejs#18698 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
|
Should this be backported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moves exposed
internalBindings to a single location with shortguidelines on how to expose them and a warning for users should they
come across it.
i would also like to take this opportunity to discuss if these tests are needed. traditionally it seems we rely on internals working by ensuring the behavior of the publicly facing apis that depend on them, but after there was a bug with module_wrap i was encouraged to create a test for it.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)