Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prototype bleeding in events.js #2044

Closed
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Correcting style to be lint-conform.
  • Loading branch information
martinheidegger committed Jun 24, 2015
commit 21706a7aa26c786a5caea202d059cf38ad3858c0
22 changes: 13 additions & 9 deletions test/parallel/test-event-emitter-prototype-bleeding.js
Original file line number Diff line number Diff line change
@@ -1,19 +1,23 @@
'use strict';
var util = require('util');
var assert = require('assert');
var EventEmitter = require('events').EventEmitter;
var called = false;

var TestClass = function () {};
TestClass.prototype = new EventEmitter;
function TestClass() {
}
TestClass.prototype = new EventEmitter();

function listener_n1() {
// This one is okay to be called!
function okListener() {
called = true;
}
function listener_n2() {
throw new Error("This one should not be called!")
function brokenListener() {
throw new Error('This one should not be called!');
}

var ok = new TestClass();
var broken = new TestClass();
broken.on('end', listener_n2);
ok.on('end', listener_n1);
ok.emit('end');
broken.on('end', okListener);
ok.on('end', brokenListener);
ok.emit('end');
assert.ok(called, 'The ok listener should have been called');