Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: minor refactor to node_errors.h #23879

Closed
wants to merge 2 commits into from
Closed

src: minor refactor to node_errors.h #23879

wants to merge 2 commits into from

Commits on Oct 25, 2018

  1. src: minor refactor to node_errors.h 

    Add overloads of the error generation/throwing methods
that take an `Isolate*` argument, since the created objects
don’t depend on the `Environment*` in question.

Also, remove `THROW_ERR_OUT_OF_RANGE_WITH_TEXT`, which did the
same thing as `THROW_ERR_OUT_OF_RANGE` in a more convoluted way.
    @addaleax
    addaleax committed Oct 25, 2018
    Configuration menu
    Copy the full SHA
    1f03ad1 View commit details
    Browse the repository at this point in the history

  2. fixup! src: minor refactor to node_errors.h

    @addaleax
    addaleax committed Oct 25, 2018
    Configuration menu
    Copy the full SHA
    dca427c View commit details
    Browse the repository at this point in the history