Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: do not reuse HTTPParser #25094

Closed
wants to merge 3 commits into from
Closed

src: do not reuse HTTPParser #25094

wants to merge 3 commits into from

Commits on Apr 21, 2019

  1. src: do not reuse async resource in http parsers 

    Change resource being used, previously HTTParser was being reused.
We are now using IncomingMessage and ClientRequest objects.  The goal
here is to make the async resource unique for each async operatio

Refs: nodejs#24330
Refs: nodejs/diagnostics#248
Refs: nodejs#21313

Co-authored-by: Matheus Marchini <mat@mmarchini.me>
    @Drieger @mmarchini @addaleax
    2 people authored and addaleax committed Apr 21, 2019
    Configuration menu
    Copy the full SHA
    1d87593 View commit details
    Browse the repository at this point in the history

  2. Update lib/_http_server.js 

    Co-Authored-By: mcollina <matteo.collina@gmail.com>
    @addaleax @mcollina
    addaleax and mcollina committed Apr 21, 2019
    Configuration menu
    Copy the full SHA
    395ddcb View commit details
    Browse the repository at this point in the history

  3. fixup! src: do not reuse async resource in http parsers

    @addaleax
    addaleax committed Apr 21, 2019
    Configuration menu
    Copy the full SHA
    7b7fed6 View commit details
    Browse the repository at this point in the history