Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: check curve ID existence instead of asn flags #25345

Closed
wants to merge 2 commits into from
Closed

src: check curve ID existence instead of asn flags #25345

wants to merge 2 commits into from

Conversation

sam-github
Copy link
Contributor

@sam-github sam-github commented Jan 4, 2019 •
edited
Loading

Simplify the code. The flag check was in the OpenSSL source, but reading
through the docs and source, it is not necessary.

Fixes: https://github.com/nodejs/node/pull/24358/files#r243099693

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@sam-github
src: check curve ID existence instead of asn flags
f11ccad 
Simplify the code. The flag check was in the OpenSSL source, but reading
through the docs and source, it is not necessary.

Fixes: https://github.com/nodejs/node/pull/24358/files#r243099693
@nodejs-github-bot
Copy link
Collaborator

@sam-github build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2139/pipeline

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. labels Jan 4, 2019
@sam-github sam-github mentioned this pull request Jan 4, 2019
Closed
4 tasks
nornagon
nornagon approved these changes Jan 4, 2019
View reviewed changes
Copy link
Contributor

@nornagon nornagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

bnoordhuis
bnoordhuis approved these changes Jan 6, 2019
View reviewed changes
src/node_crypto.cc Outdated Show resolved Hide resolved
src/node_crypto.cc Outdated Show resolved Hide resolved
@sam-github
Copy link
Contributor Author

ci: https://ci.nodejs.org/job/node-test-pull-request/19967/

@addaleax
Copy link
Member

addaleax commented Jan 8, 2019

Landed in 4a6ec3b

@addaleax addaleax closed this Jan 8, 2019
addaleax pushed a commit that referenced this pull request Jan 8, 2019
@sam-github @addaleax
src: check curve ID existence instead of asn flags
4a6ec3b 
Simplify the code. The flag check was in the OpenSSL source, but reading
through the docs and source, it is not necessary.

Refs: https://github.com/nodejs/node/pull/24358/files#r243099693
PR-URL: #25345
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
nornagon pushed a commit to electron/node that referenced this pull request Jan 8, 2019
@sam-github @nornagon
[cherry-pick] src: check curve ID existence instead of asn flags
aa582fd 
Simplify the code. The flag check was in the OpenSSL source, but reading
through the docs and source, it is not necessary.

Refs: https://github.com/nodejs/node/pull/24358/files#r243099693
PR-URL: nodejs/node#25345
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
deepak1556 pushed a commit to electron/node that referenced this pull request Jan 8, 2019
@sam-github @deepak1556
[cherry-pick] src: check curve ID existence instead of asn flags
aa7074a 
Simplify the code. The flag check was in the OpenSSL source, but reading
through the docs and source, it is not necessary.

Refs: https://github.com/nodejs/node/pull/24358/files#r243099693
PR-URL: nodejs/node#25345
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
addaleax pushed a commit that referenced this pull request Jan 9, 2019
@sam-github @addaleax
src: check curve ID existence instead of asn flags
5b93356 
Simplify the code. The flag check was in the OpenSSL source, but reading
through the docs and source, it is not necessary.

Refs: https://github.com/nodejs/node/pull/24358/files#r243099693
PR-URL: #25345
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@sam-github sam-github deleted the simplify-ec-key-info branch January 9, 2019 03:55
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@sam-github @refack
src: check curve ID existence instead of asn flags
966a05f 
Simplify the code. The flag check was in the OpenSSL source, but reading
through the docs and source, it is not necessary.

Refs: https://github.com/nodejs/node/pull/24358/files#r243099693
PR-URL: nodejs#25345
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@BridgeAR BridgeAR mentioned this pull request Jan 16, 2019
Merged
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
@sam-github @BridgeAR
src: check curve ID existence instead of asn flags
2297343 
Simplify the code. The flag check was in the OpenSSL source, but reading
through the docs and source, it is not necessary.

Refs: https://github.com/nodejs/node/pull/24358/files#r243099693
PR-URL: nodejs#25345
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
Merged
nitsakh pushed a commit to electron/node that referenced this pull request Mar 18, 2019
@sam-github @nitsakh
[cherry-pick] src: check curve ID existence instead of asn flags
7993e9d 
Simplify the code. The flag check was in the OpenSSL source, but reading
through the docs and source, it is not necessary.

Refs: https://github.com/nodejs/node/pull/24358/files#r243099693
PR-URL: nodejs/node#25345
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
nitsakh pushed a commit to electron/node that referenced this pull request Mar 18, 2019
@sam-github @nitsakh
[cherry-pick] src: check curve ID existence instead of asn flags
0186818 
Simplify the code. The flag check was in the OpenSSL source, but reading
through the docs and source, it is not necessary.

Refs: https://github.com/nodejs/node/pull/24358/files#r243099693
PR-URL: nodejs/node#25345
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
nitsakh pushed a commit to electron/node that referenced this pull request Mar 18, 2019
@sam-github @nitsakh
[cherry-pick] src: check curve ID existence instead of asn flags
5a3eb6c 
Simplify the code. The flag check was in the OpenSSL source, but reading
through the docs and source, it is not necessary.

Refs: https://github.com/nodejs/node/pull/24358/files#r243099693
PR-URL: nodejs/node#25345
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@jasnell jasnell jasnell approved these changes

@tniessen tniessen tniessen approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sam-github @nodejs-github-bot @addaleax @nornagon @bnoordhuis @jasnell @tniessen