Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: consolidate assertions in ipv6only test #26149

Closed
wants to merge 1 commit into from
Closed

test: consolidate assertions in ipv6only test #26149

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 16, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2635/pipeline

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 16, 2019
@Trott
Copy link
Member Author

Trott commented Feb 16, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/20813/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 16, 2019
@Trott
Copy link
Member Author

Trott commented Feb 16, 2019

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/20815/ ✅

@Trott
Copy link
Member Author

Trott commented Feb 18, 2019

Landed in c37b392

@Trott Trott closed this Feb 18, 2019
Trott added a commit to Trott/io.js that referenced this pull request Feb 18, 2019
@Trott
test: consolidate assertions in ipv6only test
c37b392 
PR-URL: nodejs#26149
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Feb 19, 2019
@Trott @addaleax
test: consolidate assertions in ipv6only test
da42d99 
PR-URL: #26149
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Feb 26, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@Trott @rvagg
test: consolidate assertions in ipv6only test
59ca9e9 
PR-URL: #26149
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott Trott deleted the update-assertion branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @nodejs-github-bot @jasnell @cjihrig @richardlau @BridgeAR