Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

timers: refactor timer callback initialization #26583

Closed
wants to merge 3 commits into from
Closed

timers: refactor timer callback initialization #26583

wants to merge 3 commits into from

Conversation

joyeecheung
Copy link
Member

@joyeecheung joyeecheung commented Mar 11, 2019 •
edited
Loading

timers: refactor to use module.exports

timers: reduce usage of public util

Refs: #26546

timers: refactor timer callback initialization

This patch:

  • Moves the timer callback initialization into bootstrap/node.js,
    documents when they will be called, and make the dependency on
    process._tickCallback explicit.
  • Moves the initialization of tick callbacks and timer callbacks
    to the end of the bootstrap to make sure the operations
    done before those initializations are synchronous.
  • Moves more internals into internal/timers.js from timers.js.
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@joyeecheung build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2861/pipeline

@nodejs-github-bot nodejs-github-bot added the timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. label Mar 11, 2019
@joyeecheung joyeecheung force-pushed the refactor-timers branch 2 times, most recently from fe2f5d8 to 4a99e42 Compare March 11, 2019 11:37
@joyeecheung
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/21438/

addaleax
addaleax approved these changes Mar 12, 2019
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nodejs/timers

@joyeecheung
timers: refactor to use module.exports
a53dc0b
@joyeecheung
timers: reduce usage of public util
4ac4f32 
Refs: nodejs#26546
@joyeecheung
timers: refactor timer callback initialization
4bc8ffa 
This patch:

- Moves the timer callback initialization into bootstrap/node.js,
  documents when they will be called, and make the dependency on
  process._tickCallback explicit.
- Moves the initialization of tick callbacks and timer callbacks
  to the end of the bootstrap to make sure the operations
  done before those initializations are synchronous.
- Moves more internals into internal/timers.js from timers.js.
@joyeecheung
Copy link
Member Author

joyeecheung commented Mar 18, 2019 •
edited
Loading

Rebased. CI: https://ci.nodejs.org/job/node-test-pull-request/21632/

@joyeecheung
Copy link
Member Author

Resume: https://ci.nodejs.org/job/node-test-pull-request/21639/

@joyeecheung
Copy link
Member Author

Landed in 84156cf...1a6fb71

joyeecheung added a commit that referenced this pull request Mar 18, 2019
@joyeecheung
timers: refactor to use module.exports
4980cc7 
PR-URL: #26583
Refs: #26546
Reviewed-By: Anna Henningsen <anna@addaleax.net>
joyeecheung added a commit that referenced this pull request Mar 18, 2019
@joyeecheung
timers: reduce usage of public util
7866508 
Refs: #26546

PR-URL: #26583
Reviewed-By: Anna Henningsen <anna@addaleax.net>
joyeecheung added a commit that referenced this pull request Mar 18, 2019
@joyeecheung
timers: refactor timer callback initialization
1a6fb71 
This patch:

- Moves the timer callback initialization into bootstrap/node.js,
  documents when they will be called, and make the dependency on
  process._tickCallback explicit.
- Moves the initialization of tick callbacks and timer callbacks
  to the end of the bootstrap to make sure the operations
  done before those initializations are synchronous.
- Moves more internals into internal/timers.js from timers.js.

PR-URL: #26583
Refs: #26546
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Fishrock123
Copy link
Contributor

I think the large comment block should have been moved as well...

Fishrock123 added a commit to Fishrock123/node that referenced this pull request Mar 18, 2019
@Fishrock123
timers: move big impl comment to /internal/
749d87b 
To be paired with the commits from
nodejs#26583

Specifically:
1a6fb71
@Fishrock123 Fishrock123 mentioned this pull request Mar 18, 2019
Closed
2 tasks
Fishrock123 added a commit that referenced this pull request Mar 21, 2019
@Fishrock123
timers: move big impl comment to /internal/
56199ec 
To be paired with the commits from
#26583

Specifically:
1a6fb71

PR-URL: #26761
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
targos pushed a commit that referenced this pull request Mar 27, 2019
@joyeecheung @targos
timers: refactor to use module.exports
e6367c2 
PR-URL: #26583
Refs: #26546
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request Mar 27, 2019
@joyeecheung @targos
timers: reduce usage of public util
ebb0c2a 
Refs: #26546

PR-URL: #26583
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request Mar 27, 2019
@joyeecheung @targos
timers: refactor timer callback initialization
1f4a5bc 
This patch:

- Moves the timer callback initialization into bootstrap/node.js,
  documents when they will be called, and make the dependency on
  process._tickCallback explicit.
- Moves the initialization of tick callbacks and timer callbacks
  to the end of the bootstrap to make sure the operations
  done before those initializations are synchronous.
- Moves more internals into internal/timers.js from timers.js.

PR-URL: #26583
Refs: #26546
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request Mar 27, 2019
@Fishrock123 @targos
timers: move big impl comment to /internal/
a640834 
To be paired with the commits from
#26583

Specifically:
1a6fb71

PR-URL: #26761
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@targos targos mentioned this pull request Mar 27, 2019
Merged
@kissofire kissofire mentioned this pull request Mar 7, 2021
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Mar 7, 2021
Open
@ron-a20 ron-a20 mentioned this pull request Mar 8, 2021
Open
@Rednickle Rednickle mentioned this pull request Mar 8, 2021
Open
This was referenced Mar 11, 2021
Open
Open
This was referenced May 25, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Apr 7, 2022
Open
Open
Open
Open
Open
Open
Open
Open
Closed
@snyk-bot snyk-bot mentioned this pull request Jan 30, 2023
Open
@wedataintelligence wedataintelligence mentioned this pull request Jan 30, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Jan 30, 2023
Open
@molllyn1 molllyn1 mentioned this pull request Jan 31, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Jan 31, 2023
Open
@baby636 baby636 mentioned this pull request Jan 31, 2023
Open
This was referenced Jan 31, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joyeecheung @nodejs-github-bot @Fishrock123 @addaleax