Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update V8 to 7.8 #29493

Closed
wants to merge 15 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
src: update NODE_MODULE_VERSION to 79
Major V8 updates are usually API/ABI incompatible with previous
versions. This commit adapts NODE_MODULE_VERSION for V8 7.8.

Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md
  • Loading branch information
ryzokuken committed Sep 8, 2019
commit 781ea5943ea03bdf26f286e7b142b9d989d9ab45
1 change: 1 addition & 0 deletions doc/abi_version_registry.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"NODE_MODULE_VERSION": [
{ "modules": 79, "runtime": "node", "variant": "v8_7.8", "versions": "13.0.0-pre" },
{ "modules": 78, "runtime": "node", "variant": "v8_7.7", "versions": "13.0.0-pre" },
{ "modules": 77, "runtime": "node", "variant": "v8_7.6", "versions": "13.0.0-pre" },
{ "modules": 76, "runtime": "electron", "variant": "electron", "versions": "8" },
Expand Down
2 changes: 1 addition & 1 deletion src/node_version.h
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@
* version matching should open a pull request to reserve a number in this
* registry.
*/
#define NODE_MODULE_VERSION 78
#define NODE_MODULE_VERSION 79

// The NAPI_VERSION provided by this version of the runtime. This is the version
// which the Node binary being built supports.
Expand Down