Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add explicit bracket for markdown reference links #29808

Closed

Conversation

nschonni
Copy link
Member

@nschonni nschonni commented Oct 2, 2019

Use explicit trailing [] for reference markdown links to prevent
implicit links when references are added to documents.

Separating this out from #29558

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Use explicit trailing `[]` for reference markdown links to prevent
implicit links when references are added to documents.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 2, 2019
@Trott
Copy link
Member

Trott commented Oct 4, 2019

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 4, 2019
@Trott
Copy link
Member

Trott commented Oct 4, 2019

Landed in 24011de

@Trott Trott closed this Oct 4, 2019
Trott pushed a commit that referenced this pull request Oct 4, 2019
Use explicit trailing `[]` for reference markdown links to prevent
implicit links when references are added to documents.

PR-URL: #29808
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@nschonni nschonni deleted the add-explicit-brackets-to-docs branch October 4, 2019 11:54
BridgeAR pushed a commit that referenced this pull request Oct 9, 2019
Use explicit trailing `[]` for reference markdown links to prevent
implicit links when references are added to documents.

PR-URL: #29808
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants