Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release doc #30673

Closed
wants to merge 1 commit into from
Closed

Conversation

MylesBorins
Copy link
Contributor

@MylesBorins MylesBorins commented Nov 26, 2019

Two different changes

  • Update algorithm in document to reflect the state of the script
  • Bold statement about how to re sign.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 26, 2019
doc/releases.md Outdated Show resolved Hide resolved
Updated doc to reflect what is now done in tools/release.sh
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 30, 2019
danbev pushed a commit that referenced this pull request Dec 2, 2019
Updated doc to reflect what is now done in tools/release.sh

PR-URL: #30673
Reviewed-By: Rod Vagg <rod@vagg.org>
@danbev
Copy link
Contributor

danbev commented Dec 2, 2019

Landed in c5fc802.

@danbev danbev closed this Dec 2, 2019
targos pushed a commit that referenced this pull request Dec 2, 2019
Updated doc to reflect what is now done in tools/release.sh

PR-URL: #30673
Reviewed-By: Rod Vagg <rod@vagg.org>
@BridgeAR BridgeAR mentioned this pull request Dec 3, 2019
targos pushed a commit that referenced this pull request Dec 5, 2019
Updated doc to reflect what is now done in tools/release.sh

PR-URL: #30673
Reviewed-By: Rod Vagg <rod@vagg.org>
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
MylesBorins added a commit that referenced this pull request Dec 17, 2019
Updated doc to reflect what is now done in tools/release.sh

PR-URL: #30673
Reviewed-By: Rod Vagg <rod@vagg.org>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
BethGriggs pushed a commit that referenced this pull request Dec 31, 2019
Updated doc to reflect what is now done in tools/release.sh

PR-URL: #30673
Reviewed-By: Rod Vagg <rod@vagg.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants