Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: make http2/compat.write more http/1 compliant #30964

Closed
wants to merge 4 commits into from
Closed

http2: make http2/compat.write more http/1 compliant #30964

wants to merge 4 commits into from
+74 −39

Commits on Jan 1, 2020

  1. http2: make HTTP2ServerResponse more streams compliant 

    HTTP2ServerResponse.write would behave differently than
both http1 and streams. This PR makes it more compliant
with stream.Writable behaviour.

Refs: nodejs#29529
    @ronag
    ronag committed Jan 1, 2020
    Configuration menu
    Copy the full SHA
    e09aa04 View commit details
    Browse the repository at this point in the history

  2. fixup: align with http1 instead of streams

    @ronag
    ronag committed Jan 1, 2020
    Configuration menu
    Copy the full SHA
    4684a1e View commit details
    Browse the repository at this point in the history

  3. fixup: cleaner version

    @ronag
    ronag committed Jan 1, 2020
    Configuration menu
    Copy the full SHA
    2f0d4b1 View commit details
    Browse the repository at this point in the history

  4. fixup: removed destroyed test

    @ronag
    ronag committed Jan 1, 2020
    Configuration menu
    Copy the full SHA
    9da63be View commit details
    Browse the repository at this point in the history