Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add help repo link to CONTRIBUTING.md #3233

Closed
wants to merge 3 commits into from

Conversation

dougshamoo
Copy link
Contributor

Direct help requests and technical issues that are not issues with
Node.js to the nodejs help repo issue tracker. Add link.

Fixes: #3185

Direct help requests and technical issues that are not issues with
Node.js to the nodejs help repo issue tracker. Add link.

Fixes: nodejs#3185
@@ -6,6 +6,10 @@ When opening new issues or commenting on existing issues on this repository
please make sure discussions are related to concrete technical issues with the
Node.js software.

For technical issues related to using Node.js that are not issues with the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think of something more like this: For general help using Node.js, please file an issue at... I think that may be easier to grok than issues related to using Node.js that are not issues with the Node.js software itself...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're probably right. I may have tried to go a bit to dry and technical with it. Should I do a new commit?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, go ahead with a second commit on top of this one. (You or I or someone else can squash 'em all down into one commit later.)

Thanks for tackling this, by the way!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Committed. Thanks for being awesome!

@Trott Trott added the doc Issues and PRs related to the documentations. label Oct 7, 2015
Direct help requests and technical issues that are not issues with
Node.js to the nodejs help repo issue tracker. Add link.
Update Language.

Fixes: nodejs#3185
@@ -6,6 +6,9 @@ When opening new issues or commenting on existing issues on this repository
please make sure discussions are related to concrete technical issues with the
Node.js software.

For general help using Node.js, please file an issue at the
[nodejs help repository](https://github.com/nodejs/help/issues).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps use [Node.js help repository]?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with the nit. It's Node.js in documentation and other prose so we should use that here.

@evanlucas
Copy link
Contributor

Other than that, LGTM

Direct help requests and technical issues that are not issues with
Node.js to the nodejs help repo issue tracker. Add link.
Update Language.

Fixes: nodejs#3185
@targos
Copy link
Member

targos commented Oct 7, 2015

LGTM

1 similar comment
@Trott
Copy link
Member

Trott commented Oct 8, 2015

LGTM

Trott pushed a commit that referenced this pull request Oct 8, 2015
Direct help requests and technical issues that are not issues with
Node.js to the nodejs help repo issue tracker. Add link.

PR-URL: #3233
Fixes: #3185
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott
Copy link
Member

Trott commented Oct 8, 2015

Landed in 35cdded. Thanks for the contribution!

@Trott Trott closed this Oct 8, 2015
jasnell pushed a commit that referenced this pull request Oct 8, 2015
Direct help requests and technical issues that are not issues with
Node.js to the nodejs help repo issue tracker. Add link.

PR-URL: #3233
Fixes: #3185
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@MylesBorins
Copy link
Contributor

landed in v4.x-staging in d4fc6d9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants