Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: fix codeowners docs path #34811

Closed
wants to merge 1 commit into from
Closed

meta: fix codeowners docs path #34811

wants to merge 1 commit into from

Conversation

mmarchini
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Aug 17, 2020
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@mmarchini
Copy link
Contributor Author

Fast-track to unbreak CI?

@mmarchini mmarchini added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 17, 2020
@mmarchini
meta: fix codeowners docs path
5651774 
s/docs/doc/g
Signed-off-by: Mary Marchini <mmarchini@netflix.com>
@mmarchini
Copy link
Contributor Author

Landed in 5835367

mmarchini added a commit that referenced this pull request Aug 17, 2020
@mmarchini
meta: fix codeowners docs path
5835367 
s/docs/doc/g
Signed-off-by: Mary Marchini <mmarchini@netflix.com>

PR-URL: #34811
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@mmarchini mmarchini closed this Aug 17, 2020
MylesBorins pushed a commit that referenced this pull request Aug 17, 2020
@mmarchini @MylesBorins
meta: fix codeowners docs path
76e6108 
s/docs/doc/g
Signed-off-by: Mary Marchini <mmarchini@netflix.com>

PR-URL: #34811
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@danielleadams danielleadams mentioned this pull request Aug 20, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Aug 20, 2020
@mmarchini @BethGriggs
meta: fix codeowners docs path
756c058 
s/docs/doc/g
Signed-off-by: Mary Marchini <mmarchini@netflix.com>

PR-URL: #34811
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@mmarchini @addaleax
meta: fix codeowners docs path
d3416db 
s/docs/doc/g
Signed-off-by: Mary Marchini <mmarchini@netflix.com>

PR-URL: #34811
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@mmarchini @addaleax
meta: fix codeowners docs path
fb98e76 
s/docs/doc/g
Signed-off-by: Mary Marchini <mmarchini@netflix.com>

PR-URL: #34811
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mmarchini @nodejs-github-bot @jasnell @targos @cjihrig @richardlau