Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

domain: refactor to use more primordials #35885

Closed
wants to merge 1 commit into from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Oct 30, 2020

FWIW I'm using ReflectApply to replace uses of Function.prototype.apply and Function.prototype.call because it has less overhead (see #35838 (review) for more info).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passe
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the domain Issues and PRs related to the domain subsystem. label Oct 30, 2020
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 31, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 31, 2020
@nodejs-github-bot
Copy link
Collaborator

@aduh95 aduh95 mentioned this pull request Nov 1, 2020
2 tasks
@aduh95
Copy link
Contributor Author

aduh95 commented Nov 2, 2020

@nodejs/domains can you review this please?

@aduh95 aduh95 added the review wanted PRs that need reviews. label Nov 2, 2020
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 6, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 6, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2020

Landed in 8fa9035...0ad4f70

@github-actions github-actions bot closed this Nov 6, 2020
nodejs-github-bot pushed a commit that referenced this pull request Nov 6, 2020
PR-URL: #35885
Reviewed-By: Rich Trott <rtrott@gmail.com>
@aduh95 aduh95 deleted the domain-refactor-primordials branch November 6, 2020 22:25
danielleadams pushed a commit that referenced this pull request Nov 9, 2020
PR-URL: #35885
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request Nov 9, 2020
BethGriggs pushed a commit that referenced this pull request Dec 9, 2020
PR-URL: #35885
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
PR-URL: #35885
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
PR-URL: #35885
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain Issues and PRs related to the domain subsystem. review wanted PRs that need reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants