Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap: freeze more intrinsics #38217

Merged
merged 1 commit into from
Apr 21, 2021
Merged

bootstrap: freeze more intrinsics #38217

merged 1 commit into from
Apr 21, 2021

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Apr 12, 2021

Several intrinsics were missing, and the comments were referencing an outdated version of ECMAScript spec.

Blocked on #37263, #38211, and #38215.

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Apr 12, 2021
Copy link
Contributor

@ExE-Boss ExE-Boss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These exist on primordials:

{ name: 'ArrayIterator', original: {
prototype: Reflect.getPrototypeOf(Array.prototype[Symbol.iterator]()),
} },
{ name: 'StringIterator', original: {
prototype: Reflect.getPrototypeOf(String.prototype[Symbol.iterator]()),
} },

lib/internal/freeze_intrinsics.js Outdated Show resolved Hide resolved
lib/internal/freeze_intrinsics.js Outdated Show resolved Hide resolved
Copy link
Contributor

@ExE-Boss ExE-Boss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to add these to the const { ... } = primordials block.

lib/internal/freeze_intrinsics.js Show resolved Hide resolved
lib/internal/freeze_intrinsics.js Show resolved Hide resolved
@aduh95
Copy link
Contributor Author

aduh95 commented Apr 14, 2021

You forgot to add these to the const { ... } = primordials block.

Thanks for the reminder, I didn't forget, I'm waiting for #38215 to land before putting work into this :)

@aduh95 aduh95 closed this Apr 14, 2021
@aduh95 aduh95 reopened this Apr 14, 2021
@aduh95 aduh95 marked this pull request as ready for review April 14, 2021 22:40
@aduh95 aduh95 closed this Apr 14, 2021
@aduh95 aduh95 reopened this Apr 14, 2021
@aduh95 aduh95 added the review wanted PRs that need reviews. label Apr 17, 2021
@aduh95 aduh95 requested a review from guybedford April 19, 2021 10:24
Copy link
Contributor

@guybedford guybedford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for filling these in!

@nodejs-github-bot
Copy link
Collaborator

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 19, 2021
@nodejs-github-bot
Copy link
Collaborator

PR-URL: nodejs#38217
Reviewed-By: Guy Bedford <guybedford@gmail.com>
@aduh95
Copy link
Contributor Author

aduh95 commented Apr 21, 2021

Landed in 7264dbd

@aduh95 aduh95 merged commit 7264dbd into nodejs:master Apr 21, 2021
@aduh95 aduh95 deleted the freezer branch April 21, 2021 21:21
targos pushed a commit that referenced this pull request Apr 29, 2021
PR-URL: #38217
Reviewed-By: Guy Bedford <guybedford@gmail.com>
@targos targos mentioned this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. review wanted PRs that need reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants