Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: use missing validator #38984

Closed
wants to merge 2 commits into from
Closed

Conversation

VoltrexKeyva
Copy link
Member

The net lib module's lookupAndConnect() function is missing a validator.

The `net` lib module's `lookupAndConnect()` function is missing a validator.
@github-actions github-actions bot added needs-ci PRs that need a full CI run. net Issues and PRs related to the net subsystem. labels Jun 9, 2021
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 10, 2021
@nodejs-github-bot
Copy link
Collaborator

@Lxxyx Lxxyx added request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels Jun 10, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 10, 2021
@nodejs-github-bot
Copy link
Collaborator

lib/net.js Outdated Show resolved Hide resolved
Check if the value of `options.lookup` doesn't equal to `undefined`.

Co-authored-by: James M Snell <jasnell@gmail.com>
@Lxxyx Lxxyx added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 12, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 12, 2021
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 12, 2021

@jasnell
Copy link
Member

jasnell commented Jun 14, 2021

Landed in 7a0a8ef

@jasnell jasnell closed this Jun 14, 2021
jasnell pushed a commit that referenced this pull request Jun 14, 2021
The `net` lib module's `lookupAndConnect()` function is missing
a validator.

PR-URL: #38984
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
@VoltrexKeyva VoltrexKeyva deleted the patch-3 branch June 14, 2021 15:48
danielleadams pushed a commit that referenced this pull request Jun 15, 2021
The `net` lib module's `lookupAndConnect()` function is missing
a validator.

PR-URL: #38984
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
@danielleadams danielleadams mentioned this pull request Jun 15, 2021
danielleadams pushed a commit that referenced this pull request Jun 17, 2021
The `net` lib module's `lookupAndConnect()` function is missing
a validator.

PR-URL: #38984
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
@richardlau
Copy link
Member

Backport blocked on v14.x-staging by #37045.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. net Issues and PRs related to the net subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants